runtime: land #8535 (native TypeScript transpileModule) with union conflicts resolved - #8554
Merged
Merged
Conversation
added 5 commits
August 22, 2026 00:29
…icts #8535 and the recently-merged #8532 (@parcel/watcher) both add a workspace crate, a well-known binding, and API-manifest module entries at the same insertion points. Every conflict is two independent features colliding on a list, so each resolves as a union — taking either side drops the other's symbols. docs/src/api/reference.md holds a generated entry total and is regenerated rather than resolved by hand.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (17)
📝 WalkthroughWalkthroughThe PR adds a partial native TypeScript binding backed by SWC. It supports TS/TSX transpilation, React JSX lowering, diagnostics, diagnostic flattening, compiler enums, native dispatch, public declarations, and end-to-end regression tests. ChangesTypeScript transpilation support
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant TypeScriptCode
participant PerryHIR
participant NativeDispatch
participant TypeScriptFFI
participant SWC
TypeScriptCode->>PerryHIR: import typescript APIs and enums
PerryHIR->>NativeDispatch: resolve supported exports
NativeDispatch->>TypeScriptFFI: call transpileModule
TypeScriptFFI->>SWC: parse, transform, and emit source
SWC-->>TypeScriptFFI: JavaScript output and diagnostics
TypeScriptFFI-->>TypeScriptCode: return serialized result
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands #8535 (native TypeScript
transpileModulesubset) with its conflicts against currentmainresolved.#8535 could not be merged directly: it conflicted in four files with #8532 (
@parcel/watcher), which merged first. It is a fork PR, so the rebase could not be pushed to its branch.Every conflict was a union conflict — two independent features adding at the same insertion point, where taking either side silently drops the other's symbols:
Cargo.tomlcrates/perry/well_known_bindings.toml[bindings.*]blockcrates/perry-api-manifest/src/entries.rsdocs/src/api/reference.mdThe first three are resolved as unions, keeping both features. The generated doc total is left to regeneration rather than picked by hand.
One consequence the union does not fix by itself, and the reason a naive resolution would have shipped broken:
workspace-architecture.jsonstores counters, and both PRs incremented the same ones. The union kept only one side's numbers, leaving the baseline atworkspace_members: 79/externalize: 32against a live tree of 80 / 33. That failedworkspace_architecture --checkand is corrected in a separate commit.Validation on the resolved tree:
cargo check --workspace --all-targetscheck_file_size.shworkspace_architecture.py --checkraw_handle_debt.pycheck_gc_scanner_latches.pycheck_test_registration.pyCloses #8535.
Summary by CodeRabbit
typescriptmodule and supported exports.