Update MIDI.js #493

FloppyDisk-OSC · 2026-02-03T20:50:23Z

Adds channel reporters, notes on channel array reporter, note to name reporter, and fixes a bug involving note reporter keeping the note value after the note was released

vercel · 2026-02-03T20:50:28Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
penguinmod-extensions-gallery	Ready	Preview	Feb 3, 2026 8:50pm

FloppyDisk-OSC · 2026-02-04T03:16:04Z

plz

the-can-of-soup · 2026-02-06T02:25:25Z

bump ig
please merge for @FloppyDisk-OSC's sake

the-can-of-soup · 2026-02-06T02:25:46Z

~~or give me merge perms~~

FloppyDisk-OSC · 2026-02-06T02:26:21Z

:3

FloppyDisk-OSC · 2026-02-11T23:48:02Z

MERGE PLEASEEEEEEEE

FloppyDisk-OSC · 2026-02-11T23:48:16Z

PLEASE PENGUINMOD I NEED THIS
MY EXTENSION IS KINDA UPDATELESS

Ianyourgod

small code review. note that this is just a quality of code review - i have not verified that the extension works

Ianyourgod · 2026-02-12T00:00:52Z

static/extensions/electricfuzzball_pm/MIDI.js

+    noteNumberToName(args) {
+        const noteNumber = args.NOTE;
+        if (!Number.isInteger(noteNumber) || noteNumber < 0 || noteNumber > 127) return '';
+        const names = ['C','C#','D','D#','E','F','F#','G','G#','A','A#','B'];


i am being a hater, but use " not '
not really necessary but whatever

Ianyourgod · 2026-02-12T00:02:55Z

static/extensions/electricfuzzball_pm/MIDI.js

+        const channel = args.CHANNEL;
+        const arr = [];
+        if(this.activeNotes.has(channel)) arr.push(...this.activeNotes.get(channel).keys());
+        if(this.activePads.has(channel)) arr.push(...this.activePads.get(channel).keys());


this is personal preference, but i find it a lot more readable when the condition and the body are on separate lines

agreed
unless it's something extremely short like i++ in which case that's just unnecessarily taking up space

Ianyourgod · 2026-02-12T00:10:45Z

static/extensions/electricfuzzball_pm/MIDI.js

-                return;
-            }
+    /* ======= MIDI Setup ======= */
+    _onMIDISuccess(access) {


you dont need underscores in front of function names. dont listen to the lies by big javascript!!!!

can confirm

but its pretty

Ianyourgod · 2026-02-12T00:11:35Z

static/extensions/electricfuzzball_pm/MIDI.js

+    /* ======= MIDI Setup ======= */
+    _onMIDISuccess(access) {
+        this.inputs = Array.from(access.inputs.values());
+        this.inputs.forEach(input => input.onmidimessage = e => this._onMIDIMessage(e));


just use the startlistening function

Ianyourgod · 2026-02-12T00:12:15Z

static/extensions/electricfuzzball_pm/MIDI.js

+        const channel = (status & 0x0f) + 1;
+        const isPad = (note >= 36 && note <= 51); // MPK Mini pads
+
+        if (command === 0x90 && velocity > 0) {


no magic numbers please. make constants that reflect what the numbers mean.

Ianyourgod · 2026-02-12T00:12:45Z

static/extensions/electricfuzzball_pm/MIDI.js

+    }
+
+    _noteOn(channel, note, velocity) {
+        if (!this.activeNotes.has(channel)) this.activeNotes.set(channel, new Map());


i find it more readable when conditions and bodies are on separate lines

didn't you already say that but yeah

i can read my code :P

the point is so others can read your code.

Ianyourgod · 2026-02-12T00:14:13Z

static/extensions/electricfuzzball_pm/MIDI.js

-                }
-            });
+    /* ======= Listeners ======= */
+    startListening() { this.inputs.forEach(input => input.onmidimessage = e => this._onMIDIMessage(e)); }


dont put an entire function on one line.
also, this is a big mess of closures. parentheses would be greatly appreciated.

Ianyourgod · 2026-02-12T00:16:07Z

static/extensions/electricfuzzball_pm/MIDI.js

+        if(!this.visualizerEl) return;
+        const arr = [];
+        for(const [ch, notes] of this.activeNotes.entries()){ for(const note of notes.keys()) arr.push(`N Ch${ch}:${note}`); }
+        for(const [ch, pads] of this.activePads.entries()){ for(const pad of pads.keys()) arr.push(`P Ch${ch}:${pad}`); }


these are way too long and confusing. dont put a bunch of control flow on one line

static/extensions/electricfuzzball_pm/MIDI.js

Ianyourgod · 2026-02-12T00:17:40Z

static/extensions/electricfuzzball_pm/MIDI.js

+    notesPressed() {
+        const arr = [];
+        for(const notes of this.activeNotes.values()){ for(const note of notes.keys()) arr.push(note); }
+        for(const pads of this.activePads.values()){ for(const pad of pads.keys()) arr.push(pad); }


same as a bit above. too much on one line. also the braces are unneccesary.
personal note. pretty please include a space between the brace and whatevers using it
like dont do if (blahblahblah){...
do if (blahblahblah) {... <-- notice the space

yes to the split it to multiple lines
yes to the space
no to the brace removal
i think braces make it more readable

FloppyDisk-OSC · 2026-02-12T00:51:04Z

small code review. note that this is just a quality of code review - i have not verified that the extension works

ian do i realyyyyyyyy gotta change allat to get it accepted

Ianyourgod · 2026-02-12T00:51:34Z

yes. its not that much.

FloppyDisk-OSC · 2026-02-12T00:53:38Z

yes. its not that much.

awwwwwwwwwww ok :(

FloppyDisk-OSC · 2026-02-12T02:47:16Z

i edited it

Update MIDI.js

e143962

vercel bot deployed to Preview February 3, 2026 20:50 View deployment

JeremyGamer13 added the extension update This updates an already existing extension label Feb 6, 2026

Ianyourgod requested changes Feb 12, 2026

View reviewed changes

Update MIDI.js

9dd30ca

FloppyDisk-OSC requested a review from Ianyourgod February 12, 2026 01:18

Update MIDI.js #493

Are you sure you want to change the base?

Update MIDI.js #493

Conversation

FloppyDisk-OSC commented Feb 3, 2026

Uh oh!

vercel bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FloppyDisk-OSC commented Feb 4, 2026

Uh oh!

the-can-of-soup commented Feb 6, 2026

Uh oh!

the-can-of-soup commented Feb 6, 2026

Uh oh!

FloppyDisk-OSC commented Feb 6, 2026

Uh oh!

FloppyDisk-OSC commented Feb 11, 2026

Uh oh!

FloppyDisk-OSC commented Feb 11, 2026

Uh oh!

Ianyourgod left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

the-can-of-soup Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FloppyDisk-OSC commented Feb 12, 2026

Uh oh!

Ianyourgod commented Feb 12, 2026

Uh oh!

FloppyDisk-OSC commented Feb 12, 2026

Uh oh!

FloppyDisk-OSC commented Feb 12, 2026

Uh oh!

Reviewers

vercel bot commented Feb 3, 2026 •

edited

Loading

the-can-of-soup Feb 12, 2026 •

edited

Loading