Apply Spectre Auras / Buffs from skills without needing multiple gems#9308
Draft
LocalIdentity wants to merge 1 commit intodevfrom
Draft
Apply Spectre Auras / Buffs from skills without needing multiple gems#9308LocalIdentity wants to merge 1 commit intodevfrom
LocalIdentity wants to merge 1 commit intodevfrom
Conversation
This most likely needs a fair bit of checking but should now loop through all the spectre skills in the spectre list and apply buffs without needing to go and create a spectre gem and select each spectre so the aura applies to you Raise Spectre now builds a `spectreListMinions` set so CalcPerform can spin up minion skill lists for each spectre entry. A shared funcion initialises these temporary minions without affecting the selected main spectre, and the buff processing iterates over every spectre so their auras/skills work with players/minions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8444, Fixes #9246, Fixes #7290
Description of the problem being solved:
This most likely needs a fair bit of checking but should now loop through all the spectre skills in the spectre list and apply buffs without needing to go and create a spectre gem and select each spectre so the aura applies to you
Raise Spectre now builds a
spectreListMinionsset so CalcPerform can spin up minion skill lists for each spectre entry. A shared funcion initialises these temporary minions without affecting the selected main spectre, and the buff processing iterates over every spectre so their auras/skills work with players/minionsSteps taken to verify a working solution:
Have not profiled the performance impact yet
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/ytr200y6
Before screenshot:
After screenshot: