fix(digikey): prevent crashing when no media is found for part #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-buchmann
reviewed
Dec 15, 2025
Contributor
d-buchmann
left a comment
d-buchmann
left a comment
There was a problem hiding this comment.
I think this function should never hard crash (e.g. on response status codes 500+), therefore I'd rather check if there is any content in the response, and if not, return empty.
d-buchmann
approved these changes
Dec 16, 2025
Contributor
d-buchmann
left a comment
d-buchmann
left a comment
There was a problem hiding this comment.
This can still throw a TransportException, but if it does, I think it's actually useful to let the user know =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this fixes the following crash: