Fix carousel explicit selection being overwritten by scroll sync#9
Draft
cursor[bot] wants to merge 3 commits into
Draft
Fix carousel explicit selection being overwritten by scroll sync#9cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Co-authored-by: pa7ch3s <Pa7ch3s@users.noreply.github.com>
Co-authored-by: pa7ch3s <Pa7ch3s@users.noreply.github.com>
Co-authored-by: pa7ch3s <Pa7ch3s@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Clicking or keyboard-selecting carousel tabs could settle on the wrong Core Areas tab after smooth scrolling. Reproduced on the current branch: at 480px/640px, selecting
AI Penetration Testingreverted toThick Clients; at 1024px, selectingThick Clientsreverted toWeb3 / Blockchain Security.Root cause
The debounced scroll-sync handler treated the browser's programmatic
scrollIntoView()movement from explicit selection as passive user scrolling, then recomputed the active tab from the carousel center and overwrote the user's selected tab.Fix
Suppress scroll-sync while a programmatic carousel scroll is in progress, clear suppression on
scrollendor timeout, and initialize the active tab without generating synthetic scroll work. The cleanup guard preserves normal passive scroll-sync behavior.Validation