Fix carousel explicit tab selection reverting#6
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: pa7ch3s <Pa7ch3s@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and Impact
Selecting some Core Areas tabs could visibly revert to a different tab after smooth scrolling settled. Reproduced with headless Chrome: at 480px/640px, clicking
AI Penetration Testingended onThick Clients; at 1024px, clickingThick Clientsended onWeb3 / Blockchain Security.Root Cause
The click/keyboard path calls
scrollIntoView()to center the selected tab. The carousel scroll listener then treated that programmatic smooth scroll as passive user scrolling, recomputed the active tab from the viewport center, and overwrote the explicit selection.Fix
Suppress the next debounced scroll-sync callback caused by explicit tab centering, and initialize the carousel without triggering synthetic centering.
Validation