Open
Conversation
Contributor
|
Hello! Could you fill out your initial PR description with details about your changes? |
iamajmalsaleem
commented
Oct 30, 2021
Author
iamajmalsaleem
left a comment
There was a problem hiding this comment.
Created Fixed Menu for the website
thatrobotdev
requested changes
Nov 1, 2021
Contributor
thatrobotdev
left a comment
There was a problem hiding this comment.
Thanks for clarifying what you were changing, and thank you for your contribution! I think that a fixed navbar for the site would work really well!
It looks like in the way you implemented it, there are some spacing issues on the left and right of the navbar that didn't exist before. Could you implement a fixed navbar in a way that is visually identical to the old version, but fixed?
Thanks!
Author
|
Thanks for assigning the issue. I'll try my best to fix it :) |
Fixed bug in fixed-menu-bar
Added id="nav-bar" for purpose of fixing bug on fixed-menu-bar
Author
|
Any changes ? |
Added break between NAVIGATION END and SLIDE SHOW START to adjust display
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

For Issue: #PLACE_ISSUE_NUMBER_HERE
Fixes:
Additions:
Checklist
Select one:
Screenshots