Skip to content

fix-keepalive-timeout #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmartins-unit wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −8
Open

fix-keepalive-timeout #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions share/tunnel/tunnel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,17 +174,14 @@ func (t *Tunnel) BindRemotes(ctx context.Context, remotes []*settings.Remote) er

func (t *Tunnel) keepAliveLoop(sshConn ssh.Conn) {
//ping forever

//reply_timeout set to KeepAlive interval, if KeepAlive is less than 10s, set reply_timeout to 10s
//maybe a new config option for reply_timeout is also fine
reply_timeout := t.Config.KeepAlive

if reply_timeout < 10*time.Second {
reply_timeout = 10 * time.Second
keepAliveInterval := t.Config.KeepAlive
if keepAliveInterval < 5*time.Second {
keepAliveInterval = 5 * time.Second
}

reply_timeout := 2 * time.Second
for {
time.Sleep(t.Config.KeepAlive)
time.Sleep(keepAliveInterval)

errChannel := make(chan error, 2)

Expand Down
Loading