fix: restMappings default reads d.app.restMappings, not d.app.cfengine#347
Open
zspitzer wants to merge 1 commit intoOrtus-Solutions:developmentfrom
Open
fix: restMappings default reads d.app.restMappings, not d.app.cfengine#347zspitzer wants to merge 1 commit intoOrtus-Solutions:developmentfrom
zspitzer wants to merge 1 commit intoOrtus-Solutions:developmentfrom
Conversation
Copy-paste typo: the default for app.restMappings was being read from d.app.cfengine, which means a global default cfengine (set via `config set server.defaults.app.cfengine=...`) cascades into restMappings and gets passed to runwar as a bogus URL pattern. Result: real /rest/* web.xml mapping is stripped and replaced with a non-matching pattern, so REST endpoints 404 silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line copy-paste typo at src/cfml/system/services/ServerService.cfc:264:
Reads
d.app.cfenginefor therestMappingsdefault — should bed.app.restMappings.Impact
For users who set a global default cfengine via
config set server.defaults.app.cfengine=..., the cfengine string (e.g.lucee@7,adobe@2025) cascades intorestMappingsand gets passed to runwar as a URL pattern. runwar then:servletRestEnable=true(because the value is non-empty)"lucee@7"as a single bogus URL pattern/rest/*web.xml mapping (becauseignoreWebXmlRestMappings && servletRestEnable)lucee@7URL pattern that nothing matchesResult: REST endpoints 404 silently. Affects both Lucee and ACF deployments via CommandBox.
Users without a global default cfengine are unaffected — the fallback is
''either way.Test plan
config set server.defaults.app.cfengine=lucee@7, start a server without explicitapp.restMappings, confirm REST endpoints work as expected.