Rwa muxed support - #857
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughRWA transfers now accept ChangesRWA muxed transfer support
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
Full details: Linked Issues checkExplanation The pull request addresses muxed destinations and adds related tests. However, it changes the public RWA::transfer signature even though issue Resolution Keep the public RWA::transfer signature unchanged, add a private helper that accepts the optional muxed ID, and limit the override to forwarding to.id(). Move destination rejection to a separately linked issue or provide explicit scope for it. Full details: Out of Scope Changes checkExplanation The public RWA::transfer API change and issuer-specific rejection of muxed destinations extend beyond issue
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
brozorec
left a comment
There was a problem hiding this comment.
Should we also propose an update on SEP-57?
|
Definitely! I was waiting for a review first before suggesting any change on SEP57 |
Fixes #843
PR Checklist
Credit is shared with @yigitcangokmen, will add him as a Co-Author when this PR is to be merged.
Summary by CodeRabbit