chore: bump miden-client to 0.16.0-rc.3 and web SDK to 0.16.0-rc.5 - #437
Conversation
Aligns Guardian with node 0.16.0-rc.3 (running on devnet), which changed the AccountResponse storage-map proof format that only miden-client rc.3 speaks. Protocol crates stay at 0.16.0-rc.6; the VM/crypto stack moves to 0.29.4 in the lockfile to match the WASM embedded in web SDK rc.5.
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (9)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThe pull request updates Miden Rust and npm dependency pins. It also updates compatibility documentation, multisig SDK instructions, example packages, and multisig client metadata to reference the corresponding release candidates. ChangesMiden dependency version alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR aligns the Rust and web SDK versions with the stated devnet protocol pairing, and the listed build and test checks pass. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (9 skipped: 9 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Why
Devnet is running miden-node
0.16.0-rc.3. Node rc.2 changed the RPCAccountResponsestorage-map proof format to a batchedPartialSmt(miden-node #2439), andmiden-client 0.16.0-rc.3is the release that speaks it (rust-sdk #2360). Our pinnedmiden-client 0.16.0-rc.2is therefore mismatched against devnet. The web SDK0.16.0-rc.5release bundles that same client rc.3.The protocol line did not move:
miden-protocol/miden-standards/miden-txstay at=0.16.0-rc.6, and web SDK rc.5's WASM embedsmiden-protocol-0.16.0-rc.6/miden-client-0.16.0-rc.3/miden-crypto-0.29.4. No MASM, procedure-root, or tx-summary changes.What
Cargo.toml:miden-client,miden-client-sqlite-store,miden-node-proto-buildto=0.16.0-rc.3.Cargo.lock: VM/crypto stack (miden-crypto,-core,-assembly,-processor,-prover,-verifier) 0.29.1 to 0.29.4, matching the web SDK WASM. Also picks up the single-threaded WASM prove hang fix (miden-vm #3722).@miden-sdk/miden-sdkto0.16.0-rc.5inpackages/miden-multisig-clientand the four browser examples; workspace and example lockfiles regenerated.MIDEN_COMPATIBILITY.mdsupport matrix,MULTISIG_SDK.mdandmiden-multisig-client/README.mdinstall snippets.Guardian uses none of the Rust types that changed shape in client rc.3 (
StorageMapEntries,SyncedNote,NoteObserver); our ownmiden-rpc-client::get_account_detailshas no callers. Web SDK rc.3 to rc.5 has no breaking TS API changes; thenewLocalProver()Poseidon2 change does not affect us (we only usenewRemoteProver/deserialize).Verification
cargo build --workspace --all-targetsclean.cargo test -p miden-multisig-client -p miden-rpc-client -p guardian-clientall pass, includingprocedure_roots_are_validandprocedure_roots_match_upstream_component.npm test -w miden-multisig-client: 42 files, 490/490 pass, includingprocedure-roots.test.tsand the Rust-built-account round-trip.Follow-up
Release bump to
0.17.0-rc.2is intentionally left for a separatechore(release)PR, matching #426 / #392. That PR should add an rc.2 row to the compat matrix and restore the rc.1 row tomiden-client =0.16.0-rc.2/ web SDK0.16.0-rc.3, which is what rc.1 actually shipped with.Summary by CodeRabbit
Documentation
Chores