-
Notifications
You must be signed in to change notification settings - Fork 29
build(toolchain): bump compact toolchain to 0.34.0 #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9edeca9
8fecc6a
5ca89a6
f2edf30
4a145ae
6083bb2
d742ec6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| // OpenZeppelin Compact Contracts v0.3.0-alpha.2 (access/AccessControl.compact) | ||
|
|
||
| pragma language_version >= 0.23.0; | ||
| pragma language_version >= 0.26.0; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not in the diff so I can't highlight it, but most, if not all, of the constraints are incorrect from the bump. Yet another reason to consider #829
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ^Addressed on #869 |
||
|
|
||
| /** | ||
| * @module AccessControl | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth defining what should go in the changelog at some point. To me, dev dep changes aren't important for users, they only matter for development. The important things to note are bumping the compiler and language version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can also be seen in the PR so it's not worth restating so much. That's my style on this though. If we did want to include every major detail like this, I suggest trying to make it more organized and readable e.g.
Upgrade the Compact toolchain and Midnight deps
0.31.0→0.34.0@midnight-ntwrk/compact-runtime0.16.0→0.19.0