Fix nonce reset with epoch - #819
Open
andrew-fleming wants to merge 10 commits into
Open
Conversation
andrew-fleming
marked this pull request as draft
August 21, 2026 22:14
andrew-fleming
changed the base branch from
main
to
release/v0.3.0-alpha.1-rc.0
August 21, 2026 22:15
andrew-fleming
marked this pull request as ready for review
August 21, 2026 22:23
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
0xisk
reviewed
Aug 24, 2026
0xisk
reviewed
Aug 24, 2026
0xisk
reviewed
Aug 24, 2026
0xisk
reviewed
Aug 24, 2026
0xisk
reviewed
Aug 24, 2026
0xisk
reviewed
Aug 24, 2026
0xisk
reviewed
Aug 27, 2026
Comment on lines
+92
to
+96
| * - Per-account lifetime credit count is public and permanent | ||
| * (`_creditEpochs`); unlike the memo list, it does not reset on | ||
| * `clearMemos`. | ||
| * - Per-account lifetime credit count is public and permanent | ||
| * (`_creditEpochs`). It does not reset on `clearMemos`. |
Member
There was a problem hiding this comment.
0xisk
approved these changes
Aug 27, 2026
0xisk
left a comment
0xisk
left a comment
Member
There was a problem hiding this comment.
LGTM! Thank you @andrew-fleming !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #799