Repository navigation
deps: clear the four post-sweep dependabot alerts — grpc v1.83.1 (token-recovery), otel otlptrace v1.47.0 (src) - #727
Amperstrand wants to merge 2 commits into
Conversation
…en-recovery), otel otlptrace v1.47.0 (src)
Amperstrand
left a comment
There was a problem hiding this comment.
Review (PR-REVIEW.md pass) — disposition: land (fragment conversion pending).
Small and deliberately shaped: grpc → v1.83.1 in the standalone scripts/token-recovery module (clears three GHSA advisories), and the root module's otel graph resolved to v1.47.0 by releasing a stale go.mod pin rather than adding one — go.sum already carried 1.47.0, which is the minimal-diff form of this fix. Build+vet green in both modules; full battery documented with the two pre-existing merchant reds reproduced on clean main (both now root-caused on #665 — one fixed by #718, one awaiting its own look).
One author-side fix: convert the direct CHANGELOG.md edit to changelog.d/727-deps-post-sweep.fixed.md per the fragment convention. Note for the ledger: the push-time "4 vulnerabilities" banner GitHub prints is this PR's own subject — once merged the banner clears, which will also stop confusing every future push's output.
Cross-family review —
|
|
🏷️ Next action — approved Approved; rebase + |
Amperstrand
left a comment
There was a problem hiding this comment.
Pre-review with evidence — dependabot alert clears (grpc v1.83.1 in token-recovery, otel otlptrace v1.47.0 in src). MERGEABLE against current main, both touched modules build clean on the PR tree, changelog fragment present, no API changes (pure version bumps clearing CVE alerts). Note: touchpoint overlaps the #791 fence domain (token-recovery go.mod) — the pin fence still passes because the gonuts pin is untouched. One-click approval candidate.
What
Clears the 4 dependabot alerts that surfaced on main after #681's sweep:
google.golang.org/grpc→ v1.83.1 — clears GHSA-2v4p-qf9q-27wj (high), GHSA-vp52-pcj8-j9qc (high), GHSA-qc2q-p7wx-3px3 (medium). Standalone module;go build ./...+go vet ./...green.otlptraceto v1.47.0 — clears GHSA-8wmf-6v46-5gfg (low). The fix releases the stale explicit pin insrc/go.mod(go.sum already carried 1.47.0);go build ./...+go vet ./...green.Verification
make go-batteryon this branch: merchant red with two PRE-EXISTING failures, reproduced identically on clean origin/main (cb4db7f) with zero involvement from this diff (the merchant module's go.mod is untouched): (1)TestLateReceiveOutcomeIsRecordedWhenReceiveCompletesAfterTheDeadline— the known racy assertion, fix pending in #718; (2)TestPurchaseSessionGuardHoldsThroughTheOutcomeUnknownWindow— newly discovered, deterministic in isolation on clean main, reported on #665 (last merchant-touching commits #681/#700/#619 — same #681-timing suspicion class). Every other module green.Changelog
Entry under
[Unreleased] → Changed / Internal.