Repository navigation
docs(changelog): T16 entry states the single-place reality (#396 follow-up) - #479
Conversation
…ow-up) Review wording nit on the merged entry: 'no longer import the concrete wallet package' was true of merchant_token_flow_test.go but misleading about the package — tokenfixture_test.go still imports gonuts' cashu, which is the whole design (one place, not zero places). Now phrased as the single place a wallet swap touches. [Unreleased] copy only; the alpha3 release section is frozen history.
Amperstrand
left a comment
There was a problem hiding this comment.
Informal pass — a five-line wording fix on one entry, verified against the tree rather than taken from the body: src/merchant/tokenfixture_test.go:25 is indeed the only gonuts-tollgate/cashu import left in the merchant tests (merchant_token_flow_test.go has zero), so the new "single place … plus a build-tagged sibling" phrasing is the accurate description of the T16 design, where the old "no longer import the concrete wallet package" was true of one file and misleading about the package. The [Unreleased]-only scoping is right: the v0.6.0-alpha3 section is frozen release history and gets rewritten per release, not drive-by edited. Docs-only, one file, matches the deferred finding it closes (felixfelix-bot's re-review of #396). Land.
(Note: author-account review — posted as a comment, not an approval; the branch-protection gate still needs an approving review from another account.)
|
Verification pass — docs-only PR, informal one-paragraph review per Step 1. Verified against the merged #396 squash Disposition: land (optionally with the one-word tightening above as a follow-up touching both copies; materially more accurate than what it replaces either way). |
One-line wording fix on a merged entry, from felixfelix-bot's re-review of #396 (its one finding, explicitly deferred as "fix it whenever it next lands"):
The
[Unreleased]entry now states the single-place reality:tokenfixture_test.gois the only merchant-test import of a concrete Cashu library, and a wallet swap is an edit to that one file plus a build-tagged sibling. Thev0.6.0-alpha3release-section copy is left untouched — released sections are rewritten per release, not drive-by edited.Docs-only, one file, no code.