Skip to content

docs(changelog): T16 entry states the single-place reality (#396 follow-up) - #479

Merged
Amperstrand merged 1 commit into
mainfrom
docs/changelog-t16-wording
Sep 22, 2026
Merged

Amperstrand merged 1 commit into
mainfrom
docs/changelog-t16-wording

Conversation

@Amperstrand

Copy link
Copy Markdown
Collaborator

One-line wording fix on a merged entry, from felixfelix-bot's re-review of #396 (its one finding, explicitly deferred as "fix it whenever it next lands"):

The CHANGELOG entry says "The merchant token-flow tests no longer import the concrete wallet package" — true of merchant_token_flow_test.go, misleading about the package: tokenfixture_test.go:15-19 still imports github.com/OpenTollGate/gonuts-tollgate/cashu, which is the whole design (one place, not zero places).

The [Unreleased] entry now states the single-place reality: tokenfixture_test.go is the only merchant-test import of a concrete Cashu library, and a wallet swap is an edit to that one file plus a build-tagged sibling. The v0.6.0-alpha3 release-section copy is left untouched — released sections are rewritten per release, not drive-by edited.

Docs-only, one file, no code.

…ow-up)

Review wording nit on the merged entry: 'no longer import the concrete
wallet package' was true of merchant_token_flow_test.go but misleading
about the package — tokenfixture_test.go still imports gonuts' cashu,
which is the whole design (one place, not zero places). Now phrased as
the single place a wallet swap touches. [Unreleased] copy only; the
alpha3 release section is frozen history.

@Amperstrand Amperstrand left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informal pass — a five-line wording fix on one entry, verified against the tree rather than taken from the body: src/merchant/tokenfixture_test.go:25 is indeed the only gonuts-tollgate/cashu import left in the merchant tests (merchant_token_flow_test.go has zero), so the new "single place … plus a build-tagged sibling" phrasing is the accurate description of the T16 design, where the old "no longer import the concrete wallet package" was true of one file and misleading about the package. The [Unreleased]-only scoping is right: the v0.6.0-alpha3 section is frozen release history and gets rewritten per release, not drive-by edited. Docs-only, one file, matches the deferred finding it closes (felixfelix-bot's re-review of #396). Land.

(Note: author-account review — posted as a comment, not an approval; the branch-protection gate still needs an approving review from another account.)

@Amperstrand

Copy link
Copy Markdown
Collaborator Author

Verification pass — docs-only PR, informal one-paragraph review per Step 1.

Verified against the merged #396 squash dbfd81b (3 files: tokenfixture_test.go +58, merchant_token_flow_test.go −65, CHANGELOG +5): the amended entry exists verbatim on main ([Unreleased], lines 253–257) so the edit applies cleanly; placement is correct (test-only change → Changed / Internal per AGENTS.md); style matches the neighbors (bold lead-in, ([#396](…)) link, ~78-col wrap, em-dash); the v0.6.0-alpha3 release-section copy is left untouched as the body claims (still the old wording at L645); single clean commit, no battery applies to a CHANGELOG-only diff. The new wording fixes exactly what the re-review flagged — "one place, not zero places" — and mirrors the in-code comment #396 landed at tokenfixture_test.go:5-8. One residual wrinkle, non-blocking: "the single place in the merchant tests that touches a concrete Cashu library" is strictly an overclaim — quotes_wireformat_test.go:10 and lightning_state_test.go:9 still import gonuts nut04 under the default testenv tag (the deliberate compatibility pins #396's commit message names as "left intentionally"), and offline_wallet_integration_test.go:19-21 imports gonuts wallet/cashu/nut04 behind the integration tag. The strictly-true claim is "the single place that builds test tokens through a concrete Cashu library" — if the maintainer wants that precision, change it in the changelog and the tokenfixture_test.go comment together so they don't desync (the entry inherits the comment's wording).

Disposition: land (optionally with the one-word tightening above as a follow-up touching both copies; materially more accurate than what it replaces either way).

@Amperstrand
Amperstrand merged commit 596b9e9 into main Sep 22, 2026
@Amperstrand
Amperstrand deleted the docs/changelog-t16-wording branch October 11, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant