Skip to content

docs+contract: module-count claims 16->18, and fence the backticked form \u2014 scoped rebuild of #1089 #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c03rad0r merged 1 commit into from
Oct 25, 2026
Merged

docs+contract: module-count claims 16->18, and fence the backticked form \u2014 scoped rebuild of #1089 #1111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ get wrong:

It runs `gofmt` (must print nothing), `go vet`, `go build` and
`go test -race -count=1 -tags testenv` in **every** Go module —
[src/](src/) is a multi-module tree (16 nested `go.mod` files), so
[src/](src/) is a multi-module tree (18 nested `go.mod` files), so
running those commands from `src/` alone covers only the root module
and silently skips all subpackages. One implementation:
[scripts/go-battery.sh](scripts/go-battery.sh).
Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ battery, package artifact), follow
`make manual-check`.

`make go-battery` is the full gate across all modules; the bare
`make go-battery` is the full gate across all 18 modules; the bare
`cd src && go build ./...` form covers only the root module. Go tooling
that targets one module still runs from [src/](src/), not the repo root.
The Go version is pinned in [src/go.mod](src/go.mod); CI installs
Expand Down Expand Up @@ -141,7 +142,7 @@ make go-battery
That is the same gate CI runs: `gofmt -l .` (must print nothing),
`go vet ./...`, `go build ./...` and `go test -race -count=1 -tags
testenv ./...` — executed in **every** Go module. src/ is a multi-module
tree (16 nested `go.mod` files): running the commands from `src/` alone
tree (18 nested `go.mod` files): running the commands from `src/` alone
covers only the root module and silently skips the subpackages. The one
implementation is [scripts/go-battery.sh](scripts/go-battery.sh).

Expand Down
5 changes: 4 additions & 1 deletion tests/contract/check-docs-facts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ def main() -> int:
ROOT / "scripts" / "go-battery.sh",
ROOT / "scripts" / "release-check.sh",
]
pattern = re.compile(r"(\d+)(?: nested)? (?:go\.mod files|modules)", re.IGNORECASE)
# backticked claims ("16 nested `go.mod` files") are the same claim and
# must be fenced too — they were invisible to the first pattern and had
# drifted on main while the check passed
pattern = re.compile(r"(\d+)(?: nested)? ?(?:`?go\.?mod`? ?)?(?:files|modules)", re.IGNORECASE)
claims = 0
for cf in claim_files:
if not cf.exists():
Expand Down