Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 19, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 19, 2026

🤖 Augment PR Summary

Summary: This PR adds a scale geometry effect and corresponding scale transitions to OpenSwiftUI.

Changes:

  • Introduces _ScaleEffect as a GeometryEffect that produces a scaling ProjectionTransform around a configurable UnitPoint anchor.
  • Adds View.scaleEffect overloads for CGSize, uniform CGFloat, and separate x/y scaling.
  • Implements AnyTransition.scale and a new ScaleTransition type (v5+) for insertion/removal scaling.
  • Wires ScaleTransition into content-transition effects via _makeContentTransition.
  • Adds Protobuf serialization support for _ScaleEffect.
  • Includes a small formatting cleanup in ContentTransition.swift.

Technical Notes: The new transition emits a scale effect list when the transition operation requests effects, and otherwise reports that it supports content transitions.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.91%. Comparing base (eb66fb3) to head (c58eb3c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...wiftUICore/Render/GeometryEffect/ScaleEffect.swift 0.00% 57 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (eb66fb3) and HEAD (c58eb3c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (eb66fb3) HEAD (c58eb3c)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #734       +/-   ##
===========================================
- Coverage   27.83%   13.91%   -13.93%     
===========================================
  Files         604      579       -25     
  Lines       37360    34557     -2803     
===========================================
- Hits        10401     4807     -5594     
- Misses      26959    29750     +2791     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye force-pushed the feature/scale_effect branch from 977f423 to c58eb3c Compare January 19, 2026 18:58
@Kyle-Ye Kyle-Ye merged commit 7470b20 into main Jan 19, 2026
6 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/scale_effect branch January 19, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants