Feature | Extend Swagger Coverage for controller OAuth2SummitEventsApiController#478
Conversation
08f38e3 to
acf6356
Compare
caseylocker
left a comment
There was a problem hiding this comment.
@matiasperrone-exo you have duplicate operationid values which are causing the doc generation to fail. Please fix and regenerate docs locally to verify before resubmitting.
While you're in there:
Line 84 & 133 in OAuth2SummitEventsApiControllerSchemas.php
Typo in description:
'RSVP external link, only if rsvp_template_id is not se'
Should be: '...is not set'
Thanks.
|
Thanks @caseylocker for the comments. Now is ready to review again |
caseylocker
left a comment
There was a problem hiding this comment.
openapi-generate check is failing as there is a class defined in 2 places. looks like a merge of pr 400 created duplicate a PaginatedTagsResponseSchema . Rebase and remove duplicate definition before submitting. Double check that the ci checks work as well.
1d696e9 to
b26d9ce
Compare
|
Thanks @caseylocker for catching that one. |
b26d9ce to
4ef85fa
Compare
…TypeApiController`
…ore original linting Signed-off-by: Matias Perrone <[email protected]>
…ntroller` Signed-off-by: Matias Perrone <[email protected]>
Signed-off-by: Matias Perrone <[email protected]>
Signed-off-by: Matias Perrone <[email protected]>
Signed-off-by: Matias Perrone <[email protected]>
Signed-off-by: Matias Perrone <[email protected]>
Signed-off-by: Matias Perrone <[email protected]>
Signed-off-by: Matias Perrone <[email protected]>
Signed-off-by: Matias Perrone <[email protected]>
4ef85fa to
35703b7
Compare
3e46927 to
77865a8
Compare
77865a8 to
ba6d6d4
Compare
Task:
Ref: https://app.clickup.com/t/86b6wkhda