Feat | Add OpenAPI documentation for OAuth2RocketChatSSOApiController v1#112
Open
matiasperrone-exo wants to merge 1 commit intomainfrom
Open
Feat | Add OpenAPI documentation for OAuth2RocketChatSSOApiController v1#112matiasperrone-exo wants to merge 1 commit intomainfrom
matiasperrone-exo wants to merge 1 commit intomainfrom
Conversation
matiasperrone-exo
added
the
documentation
matiasperrone-exo
added
the
documentation
matiasperrone-exo
force-pushed
the
feat/openapi----api-v1---oauth2rocketchatssoapicontroller
branch
from
1292905 to
5ce71f5
Compare
caseylocker
requested changes
Feb 22, 2026
Contributor
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
The RocketChatUserProfileSchema is created but never referenced from the endpoint's HTTP_OK response — the response uses a bare new OA\JsonContent() instead. An orphaned empty schema adds noise to the generated spec without providing value to API consumers.
Either wire it up by adding ref: '#/components/schemas/RocketChatUserProfile' to the JsonContent and marking the schema with additionalProperties: true (since the response proxies Rocket Chat's dynamic payload), or delete RocketChatUserProfileSchema.php entirely and keep the descriptive comment on the empty JsonContent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b8e6k1y