Skip to content

Add Drop Shadow and Glow effects#1060

Merged
jonoomph merged 2 commits intodevelopfrom
shadow-and-glow
Apr 21, 2026
Merged

Add Drop Shadow and Glow effects#1060
jonoomph merged 2 commits intodevelopfrom
shadow-and-glow

Conversation

@jonoomph
Copy link
Copy Markdown
Member

  • add new Shadow effect with soft drop shadow controls for color, opacity, blur, spread, distance, and angle
  • add new Glow effect with outer/inner glow modes and controls for color, opacity, blur, and spread
  • add focused unit tests covering shadow rendering, glow rendering, and JSON/property round-tripping

- add new Shadow effect with soft drop shadow controls for color, opacity, blur, spread, distance, and angle
- add new Glow effect with outer/inner glow modes and controls for color, opacity, blur, and spread
- add focused unit tests covering shadow rendering, glow rendering, and JSON/property round-tripping
@jonoomph
Copy link
Copy Markdown
Member Author

New Drop Shadow Effect

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 79.58015% with 107 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.15%. Comparing base (a36dcb5) to head (0ddcdf6).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/effects/Shadow.cpp 72.12% 46 Missing ⚠️
src/effects/Glow.cpp 72.15% 44 Missing ⚠️
src/EffectInfo.cpp 16.66% 5 Missing ⚠️
tests/Glow.cpp 95.83% 4 Missing ⚠️
tests/Shadow.cpp 95.78% 4 Missing ⚠️
src/effects/Glow.h 0.00% 2 Missing ⚠️
src/effects/Shadow.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1060      +/-   ##
===========================================
+ Coverage    65.83%   66.15%   +0.31%     
===========================================
  Files          214      220       +6     
  Lines        24232    24756     +524     
===========================================
+ Hits         15953    16377     +424     
- Misses        8279     8379     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… is applied after other keyframes are applied, to allow correct bleed/blur sizes that expand beyond their initial image sizes. Also, improved "spread" arg to be more accurate.
@jonoomph jonoomph merged commit a585652 into develop Apr 21, 2026
13 checks passed
@jonoomph jonoomph deleted the shadow-and-glow branch April 21, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant