Merged
Conversation
Member
Author
|
waiting for @lobsam fixes . not a blocker. |
TenzDelek
commented
Mar 23, 2026
| ) -> list[str]: | ||
| endpoint = f"{EXTERNAL_PECHA_API_URL}/instances/{instance_id}/segment-related?span_start={span_start}&span_end={span_end}&transform=false" | ||
| try: | ||
| response = await client.get(endpoint, headers=ACCEPT_JSON_HEADER, timeout=60.0) |
Member
Author
There was a problem hiding this comment.
timeout set as 1 min due to slow response from api server
TenzDelek
commented
Mar 23, 2026
| ) | ||
| all_segment_ids.extend(segment_ids) | ||
|
|
||
| segment_contents = await asyncio.gather( |
Member
Author
There was a problem hiding this comment.
gather the id parallely
TenzDelek
commented
Mar 23, 2026
| ) | ||
|
|
||
| collected_contents = [] | ||
| for sid, result in zip(all_segment_ids, segment_contents): |
Member
Author
There was a problem hiding this comment.
cleanup, remove unwanted error output
TenzDelek
commented
Mar 23, 2026
Comment on lines
+92
to
+96
| if collected_contents: | ||
| for content in collected_contents: | ||
| workflow_request.contexts.append( | ||
| ContextRequest(content=content) | ||
| ) |
Member
Author
There was a problem hiding this comment.
appended as context. no extra field added. make sense as it is similar to context
Member
Author
|
merging as it is not a blocker. but it should be fix to make the context better. currently we are just printing the error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #25