Skip to content

Fix real norm workspace arguments in C/ZGECXX (Reference-LAPACK PR 1447) #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-frbg merged 2 commits into from
Oct 31, 2026
Merged

Fix real norm workspace arguments in C/ZGECXX (Reference-LAPACK PR 1447) #6203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fbee89
Fix real norm workspace arguments in C/ZGECXX (Reference-LAPACK PR 1447)
martin-frbg Oct 30, 2026
a9be7b1
fix spurious return 0
martin-frbg Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions lapack-netlib/SRC/cgecxx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ typedef struct Namelist Namelist;
*/



/* Table of constant values */

static integer c_n1 = -1;
Expand Down Expand Up @@ -298,7 +297,7 @@ static integer c__1 = 1;
complex *, integer *), cswap_(integer *, complex *, integer *,
complex *, integer *);
extern real scnrm2_(integer *, complex *, integer *), clange_(char *,
integer *, integer *, complex *, integer *, complex *);
integer *, integer *, complex *, integer *, real *);
extern integer icamax_(integer *, complex *, integer *);
integer jdesel;
extern /* Subroutine */ void cgeqrf_(integer *, integer *, complex *,
Expand Down Expand Up @@ -627,11 +626,11 @@ static integer c__1 = 1;

}

if (*lwork < lwkmin && ! lquery) {
if ((*lwork < lwkmin) && ! lquery) {
*info = -26;
} else if (*lrwork < lrwkmin && ! lquery) {
} else if ((*lrwork < lrwkmin) && ! lquery) {
*info = -28;
} else if (*liwork < liwkmin && ! lquery) {
} else if ((*liwork < liwkmin) && ! lquery) {
*info = -30;
}
}
Expand Down Expand Up @@ -1031,7 +1030,7 @@ static integer c__1 = 1;

if (f2cmin(mresid,nresid) != 0) {
*fnrmk = clange_("F", &mresid, &nresid, &a[*k + 1 + (*k + 1) * a_dim1]
, lda, &work[1]);
, lda, &rwork[1]);
} else {
*fnrmk = 0.f;
}
Expand Down
2 changes: 1 addition & 1 deletion lapack-netlib/SRC/cgecxx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1627,7 +1627,7 @@ SUBROUTINE CGECXX( FACT, USESD, M, N,
*
IF( MIN( MRESID, NRESID ).NE.0 ) THEN
FNRMK = CLANGE( 'F', MRESID, NRESID, A( K+1, K+1 ),
$ LDA, WORK )
$ LDA, RWORK )
ELSE
FNRMK = ZERO
END IF
Expand Down
12 changes: 6 additions & 6 deletions lapack-netlib/SRC/zgecxx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ typedef struct Namelist Namelist;
*/



/* Table of constant values */

static integer c_n1 = -1;
Expand Down Expand Up @@ -312,13 +311,14 @@ static integer c__1 = 1;
doublereal safmin;
extern /* Subroutine */ void xerbla_(char *, integer *, ftnlen);
extern doublereal zlange_(char *, integer *, integer *, doublecomplex *,
integer *, doublecomplex *);
integer *, doublereal *);
integer mresid, nresid;
extern integer izamax_(integer *, doublecomplex *, integer *);
integer kmaxls;
extern /* Subroutine */ void zgeqrf_(integer *, integer *, doublecomplex *,
integer *, doublecomplex *, doublecomplex *, integer *, integer *
);
integer kmaxls, lwkmin;
integer lwkmin;
extern /* Subroutine */ void zlacpy_(char *, integer *, integer *,
doublecomplex *, integer *, doublecomplex *, integer *);
logical usetol, lquery;
Expand Down Expand Up @@ -634,9 +634,9 @@ static integer c__1 = 1;

if (*lwork < lwkmin && ! lquery) {
*info = -26;
} else if (*lrwork < lrwkmin && ! lquery) {
} else if ((*lrwork < lrwkmin) && ! lquery) {
*info = -28;
} else if (*liwork < liwkmin && ! lquery) {
} else if ((*liwork < liwkmin) && ! lquery) {
*info = -30;
}
}
Expand Down Expand Up @@ -1036,7 +1036,7 @@ static integer c__1 = 1;

if (f2cmin(mresid,nresid) != 0) {
*fnrmk = zlange_("F", &mresid, &nresid, &a[*k + 1 + (*k + 1) * a_dim1]
, lda, &work[1]);
, lda, &rwork[1]);
} else {
*fnrmk = 0.;
}
Expand Down
10 changes: 6 additions & 4 deletions lapack-netlib/SRC/zgecxx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,8 @@ SUBROUTINE ZGECXX( FACT, USESD, M, N,
* =====================================================================
*
* .. Parameters ..
INTEGER DP
PARAMETER ( DP = KIND( 0.0D0 ) )
DOUBLE PRECISION ZERO, TWO, MINUSONE
PARAMETER ( ZERO = 0.0D+0, TWO = 2.0D+0,
$ MINUSONE = -1.0D+0 )
Expand Down Expand Up @@ -989,7 +991,7 @@ SUBROUTINE ZGECXX( FACT, USESD, M, N,
$ ILAENV, LSAME
* ..
* .. Intrinsic Functions ..
INTRINSIC DBLE, DCMPLX, MAX, MIN
INTRINSIC CMPLX, DBLE, MAX, MIN
* ..
* .. Executable Statements ..
*
Expand Down Expand Up @@ -1248,7 +1250,7 @@ SUBROUTINE ZGECXX( FACT, USESD, M, N,
END IF
*
IF( INFO.EQ.0 ) THEN
WORK( 1 ) = DCMPLX( LWKOPT )
WORK( 1 ) = CMPLX( LWKOPT, KIND=DP )
RWORK( 1 ) = DBLE( LRWKOPT )
IWORK( 1 ) = LIWKOPT
END IF
Expand Down Expand Up @@ -1627,7 +1629,7 @@ SUBROUTINE ZGECXX( FACT, USESD, M, N,
*
IF( MIN( MRESID, NRESID ).NE.0 ) THEN
FNRMK = ZLANGE( 'F', MRESID, NRESID, A( K+1, K+1 ),
$ LDA, WORK )
$ LDA, RWORK )
ELSE
FNRMK = ZERO
END IF
Expand Down Expand Up @@ -1767,7 +1769,7 @@ SUBROUTINE ZGECXX( FACT, USESD, M, N,
*
END IF
*
WORK( 1 ) = DCMPLX( LWKOPT )
WORK( 1 ) = CMPLX( LWKOPT, KIND=DP )
RWORK( 1 ) = DBLE( LRWKOPT )
IWORK( 1 ) = LIWKOPT
*
Expand Down
Loading