Fix needed for the NPSS example #975
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmbenne3
reviewed
Jan 28, 2026
| aircraft:engine:generate_flight_idle,True,unitless | ||
| aircraft:engine:geopotential_alt,False,unitless | ||
| aircraft:engine:ignore_negative_thrust,False,unitless | ||
| aircraft:engine:interpolation_method,slinear,unitless |
Contributor
There was a problem hiding this comment.
@Kenneth-T-Moore - Perhaps we could update the variable_meta_data.py with a link to the openMDAO page documentation so that someone can easily work out what methods are available.
I think this is the doc link: https://openmdao.org/newdocs/versions/latest/features/building_blocks/components/metamodelstructured_comp.html
Does OpenMDAO have enums that we can import? Might get a bit messy if we make this an Aviary enum (in case OpenMDAO makes updates) so I think best to keep as a string for now - what do you think?
Member
Author
There was a problem hiding this comment.
I've kind of been wanting to modify OpenMDAO to use enums for all of the interpolation methods.
Member
Author
|
@cmbenne3 |
cmbenne3
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NPSS example wasn't running because of a missing variable in the aircraft csv file.
Related Issues
Backwards incompatibilities
None
New Dependencies
None