Skip to content

Comments

Remove usage limiter check on API provisioning#4442

Merged
midigofrank merged 4 commits intomainfrom
remove-api-provisioning-plan-gate
Feb 23, 2026
Merged

Remove usage limiter check on API provisioning#4442
midigofrank merged 4 commits intomainfrom
remove-api-provisioning-plan-gate

Conversation

@elias-ba
Copy link
Contributor

@elias-ba elias-ba commented Feb 20, 2026

Description

This PR removes the limit_api_provisioning usage limiter check from the provisioning API. CLI project deploy (openfn project deploy) is no longer gated by usage limits. GitHub Sync usage limiting remains unchanged.

Validation steps

Additional notes for the reviewer

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

API provisioning (openfn project deploy) should be available to all
plans. It's a core developer workflow tool, unlike GitHub Sync which
is a premium automated integration feature.

Closes OpenFn/thunderbolt#622
@github-project-automation github-project-automation bot moved this to New Issues in v2 Feb 20, 2026
The #4426 entry documented adding `api_provisioning` action type which
is now being removed. Net change for open source Lightning is zero since
the default usage limiter stub always returns :ok.
@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.38%. Comparing base (515d943) to head (75261e2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4442      +/-   ##
==========================================
+ Coverage   89.32%   89.38%   +0.05%     
==========================================
  Files         425      425              
  Lines       20196    20194       -2     
==========================================
+ Hits        18040    18050      +10     
+ Misses       2156     2144      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@midigofrank
Copy link
Collaborator

@elias-ba fyi api privisioning and github sync are the same things, so I don't think the statement "GitHub Sync usage limiting remains unchanged." is valid.

GitHub sync usage limits were incorrectly applied to all provisioning
requests including CLI deploys. Now limits are only enforced when the
actor is a RepoConnection.
@elias-ba
Copy link
Contributor Author

@midigofrank thanks for the eagle eyes. This is a great catch. I implemented the fix you proposed in my last commit. Would you mind giving me another review ? Thanks dude

@midigofrank midigofrank merged commit dc5f4dd into main Feb 23, 2026
7 checks passed
@midigofrank midigofrank deleted the remove-api-provisioning-plan-gate branch February 23, 2026 11:06
@github-project-automation github-project-automation bot moved this from New Issues to Done in v2 Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants