fix(conformance): bind verified Chat native launch correction - #226
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The binding and integrity updates warrant final human review.
Pull request overview
Updates SDK conformance evidence to verified Chat #244 native-launch corrections.
Changes:
- Refreshes producer, harness, workflow, and fixture hashes.
- Updates conformance assertions and lock metadata.
- Documents the 40-second launch budget and preserved error handling.
File summaries
| File | Description |
|---|---|
tests/conformance-gaps.spec.ts |
Updates frozen producer and fixture expectations. |
tests/conformance-contract.spec.ts |
Verifies new producer and harness bindings. |
scripts/github-conformance-evidence.mjs |
Updates reviewed workflow script hashes. |
RELEASING.md |
Documents Chat #244 validation details. |
docs/workflows/client-v1-cross-repository-conformance.md |
Updates conformance binding documentation. |
conformance/client-v1-cross-repository-lock.json |
Records verified producer metadata and hashes. |
Review details
- Files reviewed: 6/10 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bound Chat producer previously used different response budgets across its two clients and classified generic native service errors as timeouts. Bind verified Chat #244 merge
df10699bb7e1cc792ac6e197fe99d8c355e2bf18and frozen harness64932c955de3aa823732d31abd927d7a91f26632, which use the native 30-second readiness deadline plus the existing 10-second transport allowance in both clients and preserve unknown service failures.Refresh exact workflow/run fixtures, producer hashes, and documentation. Frozen counterpart revisions, assertion requirements, quotas, dependency policy, and validator acceptance logic remain unchanged.
Validation: Chat #244 exact-head CI34718152735 attempt 2 passed all ten jobs; signed actual merge preserves the tested tree and source ancestry. SDK baseline and updated conformance contracts each passed 124 tests (1 skipped). Full SDK verification passed (1513 tests, 2 skipped, including coverage), followed by a fresh 124-test conformance run and lint after refreshing the inherited native snapshot. Independent final binding review found no blockers.
After landing, rotate both validator scopes to the actual SDK merge and run fresh protected validation. The Windows publisher/token-profile root mismatch remains tracked in
cave-k0aqq.3; this binding does not claim protected acceptance. Chat and active worktrees are preserved.