Skip to content

docs: qualify cross-repository PR references - #18

Open
BunsDev wants to merge 5 commits into
mainfrom
docs/brand-ui-consolidation-audit-2026-08-31
Open

docs: qualify cross-repository PR references#18
BunsDev wants to merge 5 commits into
mainfrom
docs/brand-ui-consolidation-audit-2026-08-31

Conversation

@BunsDev

@BunsDev BunsDev commented Sep 6, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings September 6, 2026 04:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Several unqualified “#N”/“PR #N” references in the new audit doc will auto-link to this repo instead of the intended cross-repo PRs, creating incorrect documentation links.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adds two documentation artifacts (an audit snapshot and a follow-up resolution addendum) that capture the Brand/UI consolidation decision, evidence, and execution sequence, including cross-repository references to related PRs and commits.

Changes:

  • Add a comprehensive Brand/UI/design-system consolidation audit snapshot (2026-08-31) documenting decisions, risks, and an execution plan.
  • Add a short addendum (2026-09-01) recording the disposition of the urgent Brand merge hazard and remaining governance actions.
File summaries
File Description
docs/brand-ui-consolidation-audit-2026-08-31.md New audit/plan document covering repository roles, risks, and cross-repo PR triage.
docs/brand-ui-consolidation-resolution-2026-09-01.md New addendum documenting the immediate containment resolution and remaining org-level settings.
Review details

Suppressed comments (2)

docs/brand-ui-consolidation-audit-2026-08-31.md:546

  • "#2" here will auto-link to this repo; since this is referring to the UI PR, qualify it as OpenCoven/ui#2 (ideally as a link, since the surrounding text already links PRs).
- **Restack [OpenCoven/ui#3](https://github.com/OpenCoven/ui/pull/3) on the cleaned #2 or split it into reviewable PRs:** contracts/adapters, components, specimen route, registry output.

docs/brand-ui-consolidation-audit-2026-08-31.md:702

  • "After #2" will auto-link to this repository; qualify the cross-repo PR as OpenCoven/ui#2 to avoid ambiguity.
After #2 is clean, either restack or split. The developer-surface work is strategically aligned because it remains presentation-only, but 90+ stacked commits are too broad for a stable release boundary.
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Landing consumes the framework-neutral contract rather than the React package, which is appropriate. Cave deliberately re-expresses patterns. The package still needs at least one controlled consumer canary before it is treated as a stable shared dependency.

4. **Open PR topology is carrying unnecessary risk.**
PR #2 is open and currently reported non-mergeable against an old `main`; PR #3 is stacked on #2 rather than `main`; PR #6 is a draft `noop` using the same visual-review head. This obscures the actual integration sequence.
Comment thread docs/brand-ui-consolidation-audit-2026-08-31.md Outdated
@BunsDev

BunsDev commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

@copilot Fix the code for all comments in this review thread.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review thread.

Co-authored-by: BunsDev <68980965+BunsDev@users.noreply.github.com>

Copilot AI commented Sep 6, 2026

Copy link
Copy Markdown

@copilot Fix the code for all comments in this review thread.

When a review comment includes a suggested change, apply the...

Implemented the requested fixes from the linked review thread in commit 3cb8fbc by qualifying the remaining cross-repository references (OpenCoven/ui#2, OpenCoven/ui#3, OpenCoven/ui#6, and OpenCoven/brand#4) at the noted locations only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants