fix(cmd/boot): improvements to issues discovered while implementing metadata commands#97
Open
synackd wants to merge 22 commits into
Open
fix(cmd/boot): improvements to issues discovered while implementing metadata commands#97synackd wants to merge 22 commits into
synackd wants to merge 22 commits into
Conversation
ServiceBoot service name was blank, change it to "boot-service". Change default boot-service path from /boot to /boot-service to match the default HAProxy config in the release repo. Add missing block in config.MergeURIConfig() that takes into account any URI specified for boot-service when resolving service URIs. Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Provide more info while still being succinct and add a table that lists the commands available for each resource. Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
The --no-confirm flag was added for delete subcommands for the boot command, but there was no logic to prompt for deletion when not passed. This commit adds that logic. Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Check --no-confirm before checking token or performing any client actions for user to confirm if they really want to perform action early on. Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryDescription
This is a hodgepodge of small fixes to issues that were discovered in boot service commands/libraries/docs while implementing the up-and-coming metadata-service commands. They include:
--uriand--cluster-uri), which was not occurring/bootto/boot-serviceto match default release config-d/--datarequirement when passing data to stdin (the flag was formerly necessary when passing data to stdin)--no-confirmbehavior:--no-confirm=falsedoes not automatically comfirmboot bmc addcan add more than one BMC at a time--patch-formatto--patch-format_uid_tosetcommands in ochami-boot(1)Type of Change
For more info, see Contributing Guidelines.