ROM k-eigenvalue implementation#11
Conversation
| * Each group basis is read from the corresponding libROM basis file and | ||
| * stored in \c Ugs_. The reduced dimension is inferred from the first | ||
| * basis and stored in \c rom_rank. | ||
| */ |
There was a problem hiding this comment.
Doxygen usually goes into the header file, not the .cc file.
But I see other functions have doxygen here, maybe that should be unified within the app in a separate PR.
There was a problem hiding this comment.
I will have one or two more PRs to finish merging in all of my work I will move them in a future PR
wdhawkins
left a comment
wdhawkins
left a comment
There was a problem hiding this comment.
If you haven't already, please run clang-tidy and flake8 on your changes.
| errors = [] | ||
| for g in range(G): | ||
| rom_vals[g] /= np.linalg.norm(rom_vals[g]) | ||
| rom_vals = np.abs(rom_vals) |
There was a problem hiding this comment.
It might be better to use a local array here instead of modifying rom_vals while you're looping over it.
There was a problem hiding this comment.
I wanted it to be modified so the later error calculation is done on the normalized flux. I have seperated it out to make it more clear that I am normalizing then plotting.
3 participants
Contains my k-eigenvalue implementation as well as READMEs for each of the subfolders. I included an additional example in the workflow that runs a k-eigenvalue problem.