Add support for .NET 8 #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyTroeff
requested review from
SharePointRadi and
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
This pull request adds .NET 8 support to the OneBitSoftware.Utilities.OperationResult library, enabling multi-targeting for both .NET 8.0 and .NET 9.0 frameworks.
- Updated project files to target both net8.0 and net9.0 frameworks
- Added framework-specific package references for Microsoft.Extensions.Logging.Abstractions
- Updated CI/CD workflow to install and test against both .NET SDK versions
- Incremented package version from 2.1.0 to 2.1.1
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/OneBitSoftware.Utilities.OperationResultTests/OneBitSoftware.Utilities.OperationResultTests.csproj | Changed from single-target (net9.0) to multi-target (net8.0;net9.0) configuration |
| src/OneBitSoftware.Utilities.OperationResult/OneBitSoftware.Utilities.OperationResult.csproj | Updated to multi-target net8.0 and net9.0, added conditional package references for framework-specific logging abstractions versions, and bumped package version to 2.1.1 |
| .github/workflows/pull-request-validation.yml | Updated to install both .NET 8.x and 9.x SDKs and added configuration flag to test command for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/OneBitSoftware.Utilities.OperationResult/OneBitSoftware.Utilities.OperationResult.csproj
Show resolved
Hide resolved
SharePointRadi
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.