initial draft for OVM predeploy guide#113
initial draft for OVM predeploy guide#113nickh-obol merged 4 commits intonick/ovm-predeploy-guidefrom
Conversation
|
most of my changes come from bringing in pre-creation of splitters, and getting rid of giving the backend api key roles, and instead letting it be an owner until it shouldn't be. Need to update the sequence diagram to correctly reflect this change, and i think i didn't do the splits stuff in forge or typescript, only cast (and untested at that). Maybe @nickh-obol you can update the sequence diagram for me and polish up what i missed? (and then merge this pr into yours, and merge that into main, allowing us to close #114 which i'm just using to review the pre-deploy guide). |
| {% tabs %} | ||
| {% tab title="Cast" %} | ||
|
|
||
| Run these commands 50 times. (You may need to use `createSplitDeterministic()` with a salt value or use different placeholder recipient addresses for the PullSplits or the command will error due to a split with that configuration already existing) |
There was a problem hiding this comment.
I think we should avoid talking about 50 contracts, can easily extrapolate a single example. Might confuse people, and dealing with one as a proof of concept is easier.
If we're calling the factory it seems we avoid the problem with deterministic contracts since it adds a nonce already? https://docs.splits.org/core/split-v2#notes
| 0xOwnerKeyAddress 0xOwnerKeyAddress 0xOwnerKeyAddress 16000000000 \ | ||
| --rpc-url https://ethereum-hoodi-rpc.publicnode.com \ | ||
| --private-key 0x... | ||
| $BACKEND_API_ADDRESS $BACKEND_API_ADDRESS $BACKEND_API_ADDRESS 16000000000 \ |
There was a problem hiding this comment.
I don't think it ever updates this from the default value for fee recipient
| ```sh | ||
| # Create a keypair with `cast wallet new`. Put some (hoodi)Eth in the corresponding address. | ||
| # (Make sure you don't commit it to version control!) | ||
| export DEPLOYER_PRIVATE_KEY=0xPrivateKeyForADeployer |
There was a problem hiding this comment.
Unused, now that we've moved the permissions to the API
* initial draft for OVM predeploy guide * update index * fix tabs * add cast examples * add principalThreshold warning link and update graphic colors * initial draft for OVM predeploy guide (#113) * Cosmetic updates * Image * Update demo * Update code snippits, diagram. Set fee recipient to deployed splitter. --------- Co-authored-by: nick_h <[email protected]> --------- Co-authored-by: Oisín Kyne <[email protected]>
2 participants
Don't merge yet, just pushing my wip so far so i can see the branch build of it
(some of the diff is from calling a markdown formatter)