Skip to content

Conversation

@Mysterio-17
Copy link
Contributor

Description

Upgrades Vite from 5.4.21 to 7.3.1 as per the latest release.

Changes

  • ⬆️ Vite: 5.4.217.3.1
  • ⬆️ @sveltejs/vite-plugin-svelte: 4.0.46.2.4 (required for Vite 7 compatibility)
  • ⬆️ Vitest: 3.2.44.0.17 (Vite 7 compatible)

Testing

  • ✅ All 6 tests passing
  • ✅ Dev server running successfully
  • ✅ Production build succeeds
  • ✅ Test coverage maintained at 60%

Notes

  • No breaking changes to application functionality
  • All core functionality verified and working

Related

@Mysterio-17
Copy link
Contributor Author

Hi @sydseter, all checks have passed. Kindly review this PR

@sydseter
Copy link
Collaborator

sydseter commented Jan 21, 2026

I’ll test this and get back to you.

@sydseter
Copy link
Collaborator

sydseter commented Jan 21, 2026

Thank you for all your efforts.

@sydseter sydseter self-assigned this Jan 21, 2026
@Mysterio-17
Copy link
Contributor Author

Great experience working in this repo.
Can i contribute in other issues also?

sydseter
sydseter previously approved these changes Jan 22, 2026
@sydseter
Copy link
Collaborator

@Mysterio-17 Could you update your commits so that they have a verified signature? ref: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@Mysterio-17
Copy link
Contributor Author

@sydseter, I've updated my commits with a verified signature. You may review it and merge the same

@sydseter
Copy link
Collaborator

@Mysterio-17 Thank you for this. Could you make sure the build is passing as well?

@Mysterio-17
Copy link
Contributor Author

@sydseter, Yes I've fixed the build tests, you may review the PR

@sydseter
Copy link
Collaborator

@Mysterio-17 Great! If you want you can add yourself to the contributor list: https://github.com/OWASP/cornucopia/blob/master/cornucopia.owasp.org/data/website/pages/about/en/index.md#volunteers

The list is alphabetical.

@sydseter
Copy link
Collaborator

@Mysterio-17 could you delete the lock file and recreate it. There is a conflict. Also: If you want you can add yourself to the contributor list: https://github.com/OWASP/cornucopia/blob/master/cornucopia.owasp.org/data/website/pages/about/en/index.md#volunteers

@Mysterio-17
Copy link
Contributor Author

@sydseter, I've implemented the lock file again and checked the tests, also added my name in the contributor list.
It's good to go

@Mysterio-17
Copy link
Contributor Author

@sydseter, i ran all the tests again locally and verified them. Can you kindly run the checks again

@Mysterio-17
Copy link
Contributor Author

@sydseter , I rectified the names' order.

@sydseter
Copy link
Collaborator

sydseter commented Jan 26, 2026

@Mysterio-17, you need to run pnpm install and submit the lockfile again, as the changes you merged from master require the lock file to be regenerated to be valid.

@Mysterio-17
Copy link
Contributor Author

@sydseter, I modified the lockfile again and checked for tests locally

@sydseter sydseter merged commit 6042bef into OWASP:master Jan 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants