-
Notifications
You must be signed in to change notification settings - Fork 7
PhasorDynamics simulations with sparse Jacobians #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f80e836 to
8a6ddd0
Compare
05e2ddb to
3285026
Compare
examples/PhasorDynamics/Tiny/ThreeBus/Classical/ThreeBusClassical.cpp
Outdated
Show resolved
Hide resolved
0a47f42 to
ad67082
Compare
…m for the sparsity pattern analysis.
9404058 to
f470a32
Compare
pelesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! All tests pass and the PR fixes quite a few minor issues along the way. I left a few nitpicking comments mainly requesting better documentation within the code.
PhilipFackler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
This adds the ability to run
PhasorDynamicsexamples with sparse Jacobian. The component Jacobians are obtained with Enzyme and assembled into the system Jacobian.cc @lukelowry @abirchfield
Proposed changes
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
This is still using
COO_Matrix. I suggest we merge #307 and re-use Jacobian assembly.Comparison plots between current (sparse Jacobians) and reference (dense Jacobians computed by IDA with finite differences)
ThreeBus_Basic

ThreeBus_Classical

TenGenGenrou

TenGenGenClassical
