Skip to content

Rename the macros incorrectly associated with CMR to EDL#1383

Closed
ndp-opendap wants to merge 1 commit into
masterfrom
ndp/rename-ngap-macro
Closed

Rename the macros incorrectly associated with CMR to EDL#1383
ndp-opendap wants to merge 1 commit into
masterfrom
ndp/rename-ngap-macro

Conversation

@ndp-opendap

@ndp-opendap ndp-opendap commented Jun 10, 2026

Copy link
Copy Markdown
Contributor
  • Rename the macro CMR_CLIENT_ID_CONTEXT_KEY to EDL_CLIENT_APPLICATION_ID_CONTEXT_KEY
  • Rename the macro CMR_CLIENT_ID_KEY to EDL_CLIENT_APPLICATION_ID_REQUEST_HEADER_KEY

The values of these macros are EDL things, not CMR things, even though CMR might want/use/need them.

Description

Reference ticket: HYRAX-####

TODO

Tasks

  • Ticket exists and is linked in title
  • Tests added/updated
  • Dead code removed
  • No TODOs added

…N_ID_CONTEXT_KEY

- Rename the macro CMR_CLIENT_ID_KEY to EDL_CLIENT_APPLICATION_ID_REQUEST_HEADER_KEY
These the values of these macros are EDL things, not CMR things, even though CMR might want/use/need them.
@ndp-opendap ndp-opendap linked an issue Jun 10, 2026 that may be closed by this pull request
@ndp-opendap ndp-opendap changed the title Rename the incorrectly associated CMR to more accurate EDL macros Rename the macros incorrectly associated with CMR to EDL Jun 10, 2026
@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@ndp-opendap

Copy link
Copy Markdown
Contributor Author

OBE

@ndp-opendap ndp-opendap deleted the ndp/rename-ngap-macro branch June 10, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename some macros whose names create confusion

2 participants