Skip to content

Prep v1.8.1 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-omophub merged 1 commit into from
Jun 1, 2026
Merged

Prep v1.8.1 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: omophub
Title: R Client for the 'OMOPHub' Medical Vocabulary API
Version: 1.8.0
Version: 1.8.1
Authors@R: c(
person("Alex", "Chen", email = "alex@omophub.com", role = c("aut", "cre", "cph")),
person("Observational Health Data Science and Informatics", role = c("cph"))
Expand Down
11 changes: 11 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
# omophub 1.8.1

## Changed

* **Canonical endpoint path** — `client$search$semantic()` and
`client$search$semantic_all()` now call `GET /v1/search/semantic` instead of
`GET /v1/concepts/semantic-search`. The legacy path remains a permanent
server-side alias (emits `Deprecation: true` + `Link: …rel="successor-version"`
headers), so older installations of this SDK continue to work - no breaking
change for callers.

# omophub 1.8.0

## New Features
Expand Down
2 changes: 1 addition & 1 deletion R/search.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ SearchResource <- R6::R6Class(
params$threshold <- threshold
}

perform_get(private$.base_req, "concepts/semantic-search", query = params)
perform_get(private$.base_req, "search/semantic", query = params)
},

#' @description
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-search.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ test_that("search$semantic calls correct endpoint", {

resource$semantic("heart attack", page = 1, page_size = 20)

expect_equal(called_with$path, "concepts/semantic-search")
expect_equal(called_with$path, "search/semantic")
expect_equal(called_with$query$query, "heart attack")
expect_equal(called_with$query$page, 1L)
expect_equal(called_with$query$page_size, 20L)
Expand Down
Loading