-
-
Notifications
You must be signed in to change notification settings - Fork 879
[16.0][ADD] add project_reviewer #1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
05ee56a to
68fc477
Compare
Kev-Roche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
project_reviewer/__manifest__.py
Outdated
| "development_status": "Alpha", | ||
| "category": "Uncategorized", | ||
| "website": "https://github.com/OCA/project", | ||
| "author": " Akretion, Odoo Community Association (OCA)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"author": "Akretion, Odoo Community Association (OCA)",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the catch
project_reviewer/__manifest__.py
Outdated
| "summary": "Add the possibility to assign reviewer to a task", | ||
| "version": "16.0.1.0.0", | ||
| "development_status": "Alpha", | ||
| "category": "Uncategorized", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"category": "Project",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the catch
| @@ -0,0 +1 @@ | |||
| This module allow to set several reviewers on a project task | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, open question, you add users as reviewers of the project, but don't add them specific user rights to be able to access this project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I didn't need to change the access right. The idea is not to define new access right but just to define who is responsible of doing the review for the code that will be written. (Our aim is to be more organize for doing review inside the OCA)
68fc477 to
7bd9c0a
Compare
|
@CristianoMafraJunior it should be ok now |
Simple module that add the field reviewer_ids on the project task
@florian-dacosta @Kev-Roche