UI Expansion and Smarter Soultrap: Rational Names compat#67
Open
danaYatsuta wants to merge 5 commits intoNullCascade:masterfrom
Open
UI Expansion and Smarter Soultrap: Rational Names compat#67danaYatsuta wants to merge 5 commits intoNullCascade:masterfrom
danaYatsuta wants to merge 5 commits intoNullCascade:masterfrom
Conversation
Author
|
Also added compat for Smarter Soultrap ("displaced from ..." and "relocated from ... to ..." notifications) |
danaYatsuta
changed the title
Collaborator
|
Confirmed this works nicely. Holding off on merging for now as we're discussing if we might want support overriding names in MWSE natively, so it doesn't need to be mod specific. Will get back to you at some point, if a native MWSE solution doesn't emerge then I'll merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Rational Names installed, attribute/skill tooltips show technical name of items contributing to the stat with the prefix added by RN. This PR implements using RN's interop to get item's display name if it's installed.
Before:
After:
