Repository navigation
Conversation
main added the boolean per-route daybreak flag after #218 branched; the preset snapshot checked every editor route key as a string, so saving or listing a preset with a Daybreak route failed with 'Route field daybreak must be a string'. Daybreak is checked as a bool (shape only for saved presets, full catalog check at save/use).
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #218 by @thebergerking91 (both commits cherry-picked, authorship kept), rebased onto current
main.Supersedes #218.
Fixes #217
What it adds (unchanged from #218): named model-route presets for Model routes mode —
hermes delegation preset save|list|show|use|rename|delete,/delegation preset NAME [--now], and a profile-scoped/api/plugins/advanced-delegation/presetsAPI (names + active marker only; snapshots never cross it). Presets live indelegation.backends.model_map.presets; using one switchesdelegation.backendtomodel_mapand replacesoptions/default, so there is still one active mode.What changed in the salvage
model_map.pyconflict with main's Daybreakroute_keysproperty (kept both).daybreak: trueflag (added after feat(advanced-delegation): save and switch named route presets #218 branched) broke presets — the snapshot type-checked every editor route key as a string, so saving or listing a preset with a Daybreak route raisedRoute field daybreak must be a string. Daybreak is now checked as a bool (shape-only for stored presets, full catalog check at save/use). New testtest_daybreak_route_survives_a_preset_round_tripfails without the fix, passes with it.Verification: advanced-delegation suite 342 passed, 4 skipped (main: 163/2);
evals/ci.sh(node dashboard packaging test) green.Core dependency: the Desktop dropdown and session-pinned routes need NousResearch/hermes-agent#145845 (open). On current core the plugin feature-detects:
update_user_configabsent → guardedatomic_config_writepath;snapshot_settingsis simply not called.