Skip to content

feat(advanced-delegation): save and switch named route presets (salvage #218) - #434

Closed
teknium1 wants to merge 3 commits into
mainfrom
salvage/218-route-presets
Closed

teknium1 wants to merge 3 commits into
mainfrom
salvage/218-route-presets

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Salvage of #218 by @thebergerking91 (both commits cherry-picked, authorship kept), rebased onto current main.

Supersedes #218.
Fixes #217

What it adds (unchanged from #218): named model-route presets for Model routes mode — hermes delegation preset save|list|show|use|rename|delete, /delegation preset NAME [--now], and a profile-scoped /api/plugins/advanced-delegation/presets API (names + active marker only; snapshots never cross it). Presets live in delegation.backends.model_map.presets; using one switches delegation.backend to model_map and replaces options/default, so there is still one active mode.

What changed in the salvage

  • Resolved the model_map.py conflict with main's Daybreak route_keys property (kept both).
  • Fix on top: main's per-route daybreak: true flag (added after feat(advanced-delegation): save and switch named route presets #218 branched) broke presets — the snapshot type-checked every editor route key as a string, so saving or listing a preset with a Daybreak route raised Route field daybreak must be a string. Daybreak is now checked as a bool (shape-only for stored presets, full catalog check at save/use). New test test_daybreak_route_survives_a_preset_round_trip fails without the fix, passes with it.

Verification: advanced-delegation suite 342 passed, 4 skipped (main: 163/2); evals/ci.sh (node dashboard packaging test) green.

Core dependency: the Desktop dropdown and session-pinned routes need NousResearch/hermes-agent#145845 (open). On current core the plugin feature-detects: update_user_config absent → guarded atomic_config_write path; snapshot_settings is simply not called.

thebergerking91 and others added 3 commits November 19, 2026 03:56
main added the boolean per-route daybreak flag after #218 branched; the preset snapshot checked
every editor route key as a string, so saving or listing a preset with a Daybreak route failed
with 'Route field daybreak must be a string'. Daybreak is checked as a bool (shape only for
saved presets, full catalog check at save/use).
@teknium1

Copy link
Copy Markdown
Contributor Author

Landed on main via #446 (tip aeff655), stacked with the other reviewed official PRs so shared files conflicted only once. To get it now: hermes plugins install NousResearch/hermes-official-plugins#<plugin> --force; hermes plugins update follows once the catalog pin moves (in progress).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

advanced-delegation: save and switch named sets of model routes (presets)

2 participants