Skip to content

fix(homeassistant): reuse one persistent notification for agent replies (salvage #3) - #431

Closed
teknium1 wants to merge 1 commit into
mainfrom
salvage/3-reuse-notification
Closed

teknium1 wants to merge 1 commit into
mainfrom
salvage/3-reuse-notification

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Salvage of #3 (port of NousResearch/hermes-homeassistant#4 by @CoronaCowboy), rebased onto current main; authorship kept (Chuck Bryan).

  • Routine Hermes replies to Home Assistant reuse one persistent notification (notification_id: hermes_agent) instead of piling up in the HA notification panel.
  • platforms.homeassistant.extra.notification_id picks a different id; an empty string keeps HA's create-a-new-one-per-reply behaviour.
  • Only conflict was the README settings table / __init__ next to the newer ws_heartbeat_seconds; both kept.

Note: this changes the default — a new reply replaces the previous unread one in the panel. Set notification_id: "" to get the old behaviour back.

Tests: the new payload assertions fail on main (2 failed) and pass here; homeassistant suite 216 passed, 2 skipped.

Supersedes #3.

@teknium1

Copy link
Copy Markdown
Contributor Author

Landed on main via #446 (tip 0af01cf), stacked with the other reviewed official PRs so shared files conflicted only once. To get it now: hermes plugins install NousResearch/hermes-official-plugins#<plugin> --force; hermes plugins update follows once the catalog pin moves (in progress).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant