Repository navigation
Conversation
…act, drop the fork patch script - Every pick goes through setAccentOverride/normalizeHex; typed text that is not a colour no longer lands raw in $accentOverride or in storage. - One persist() in register() writes ctx.storage at once and the data-folder copy once a drag settles (was a file write per pointer move). - Disabling the plugin clears the live override again (the saved pick stays and comes back on re-enable), so no colour is stranded without a control. - Remove patch/: its script rewrote the user's catalog entry to a personal fork and sha. - plugin.yaml 1.1.0; README text no longer says the colour is never persisted.
Contributor
|
Thank you @Icarus-B4! This landed on main through #446, which stacked the 34 reviewed official-plugin PRs on current main so their shared files (CHANGELOGs, versions, the README grid) conflicted only once. Your commits are kept with your authorship; this PR's tip is 3e5d075. To get it now: |
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Accent Picker shipped with setAccentOverride, which is deliberately scratch-only — the color resets on every launch. This PR makes the picker persist the chosen accent across restarts.
Changes:
src/plugin.tsx: restore the persisted accent at register() time (so it applies on startup, not only when the popover opens); pass ctx through to the trigger; remove the onDispose handler that cleared the override on unload (which previously clobbered the saved value); update description.
src/picker.tsx: accept ctx as a prop; persist via both ctx.storage (fast, sync) and ctx.files (disk, robust against Electron webview localStorage loss); restore on mount from both; switch from setAccentOverride to $accentOverride.set to avoid normalization drift.
desktop/plugin.js: rebuilt.
Persistence strategy: two-tier — ctx.storage for immediate sync reads, ctx.files (plugin data folder) as the durable disk layer. Restore runs at plugin load so the color is active before the UI renders.
Testing: manually verified accent survives a full Hermes restart and applies on startup without opening the picker.