Skip to content

fix(agent-importers): pin the cron resume hint to the imported profile - #290

Closed
ree2507 wants to merge 1 commit into
NousResearch:mainfrom
ree2507:fix/issue-265-profile-resume-hint
Closed

ree2507 wants to merge 1 commit into
NousResearch:mainfrom
ree2507:fix/issue-265-profile-resume-hint

Conversation

@ree2507

@ree2507 ree2507 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #265 (the per-profile resume hint half)

What this changes

Importing a Grok Bot or OpenBot into a named profile printed
hermes cron resume <id> without a -p selector, so the hint failed when
pasted from any other profile — the resume ran against the caller's cron
store and reported Job with ID or name '<id>' not found.

_print_routine_next_steps() now pins the hint to the profile the import
targeted, using core's hermes_constants.profile_cli_selector() — the same
helper hermes_cli/auth.py and doctor_state.py use for their
copy-pasteable guidance. The default profile keeps the bare
hermes cron resume form, so single-profile behavior is unchanged.

Testing

  • New end-to-end test test_the_resume_hint_is_pasteable_from_a_named_profile
    (RED first: reproduced the missing -p; GREEN after the fix). It mirrors
    the issue's repro: the profile home is created explicitly, the import runs,
    and the output must contain hermes -p scout cron resume with no bare
    hermes cron resume form left.
  • Full agent-importers suite: 133 passed, 1 skipped (baseline was
    132 passed, 1 skipped — the only delta is the new test).
  • python -m hermes_cli.main plugins validate ./agent-importers → passed.

Scope

Touches only agent-importers. The multi-Bot half of #265 (several Bots
merging into one agent / "one profile per Bot") is a design decision — I
would like to follow the maintainer's direction on it before coding, as
asked in the issue comment.

Importing a Grok Bot or OpenBot into a named profile printed
'hermes cron resume <id>' without a -p selector, so the hint failed
when pasted from any other profile: the resume ran against the
caller's cron store and did not find the job (NousResearch#265).

The hint now carries the profile's -p selector via
hermes_constants.profile_cli_selector(), the same helper core uses
for its copy-pasteable guidance; the default profile keeps the bare
form. Existing suite extended with a named-profile end-to-end test.
@ree2507
ree2507 force-pushed the fix/issue-265-profile-resume-hint branch from e5b4906 to 9a96d29 Compare November 14, 2026 16:19
teknium1 added a commit to salch-cred/hermes-official-plugins that referenced this pull request Nov 19, 2026
… not the launch env

The process env holds the launch profile's channels: a job imported into another
profile cannot deliver through them. Platform ids now match cron's deliver tokens
(qqbot; no bare qq). The config.yaml home_channel branch read PyYAML, which core no
longer ships; the broad except hid the ImportError, so it never matched — it now goes
through the plugin's load_config_file. The preview row (destination) carries
'delivers to <x>', and the local-output hint names the target profile's cron/output.
Test moved off the hunk NousResearch#290/NousResearch#394 edit so the three PRs merge cleanly.
teknium1 added a commit that referenced this pull request Nov 19, 2026
… not the launch env

The process env holds the launch profile's channels: a job imported into another
profile cannot deliver through them. Platform ids now match cron's deliver tokens
(qqbot; no bare qq). The config.yaml home_channel branch read PyYAML, which core no
longer ships; the broad except hid the ImportError, so it never matched — it now goes
through the plugin's load_config_file. The preview row (destination) carries
'delivers to <x>', and the local-output hint names the target profile's cron/output.
Test moved off the hunk #290/#394 edit so the three PRs merge cleanly.

(cherry picked from commit 36ca96c)
@teknium1

Copy link
Copy Markdown
Contributor

Thank you @ree2507! This landed on main through #446, which stacked the 34 reviewed official-plugin PRs on current main so their shared files (CHANGELOGs, versions, the README grid) conflicted only once. Your commits are kept with your authorship; this PR's tip is 381f1dd. To get it now: hermes plugins install NousResearch/hermes-official-plugins#<plugin> --force; hermes plugins update follows once the catalog pin moves (in progress).

@teknium1 teknium1 closed this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[agent-importers] Grok Bot: several Bots merge into one agent, and the per-profile path prints a resume command that fails

2 participants