Repository navigation
Conversation
This was referenced Nov 9, 2026
4 tasks
Importing a Grok Bot or OpenBot into a named profile printed 'hermes cron resume <id>' without a -p selector, so the hint failed when pasted from any other profile: the resume ran against the caller's cron store and did not find the job (NousResearch#265). The hint now carries the profile's -p selector via hermes_constants.profile_cli_selector(), the same helper core uses for its copy-pasteable guidance; the default profile keeps the bare form. Existing suite extended with a named-profile end-to-end test.
ree2507
force-pushed
the
fix/issue-265-profile-resume-hint
branch
from
November 14, 2026 16:19
e5b4906 to
9a96d29
Compare
teknium1
added a commit
to salch-cred/hermes-official-plugins
that referenced
this pull request
Nov 19, 2026
… not the launch env The process env holds the launch profile's channels: a job imported into another profile cannot deliver through them. Platform ids now match cron's deliver tokens (qqbot; no bare qq). The config.yaml home_channel branch read PyYAML, which core no longer ships; the broad except hid the ImportError, so it never matched — it now goes through the plugin's load_config_file. The preview row (destination) carries 'delivers to <x>', and the local-output hint names the target profile's cron/output. Test moved off the hunk NousResearch#290/NousResearch#394 edit so the three PRs merge cleanly.
teknium1
added a commit
that referenced
this pull request
Nov 19, 2026
… not the launch env The process env holds the launch profile's channels: a job imported into another profile cannot deliver through them. Platform ids now match cron's deliver tokens (qqbot; no bare qq). The config.yaml home_channel branch read PyYAML, which core no longer ships; the broad except hid the ImportError, so it never matched — it now goes through the plugin's load_config_file. The preview row (destination) carries 'delivers to <x>', and the local-output hint names the target profile's cron/output. Test moved off the hunk #290/#394 edit so the three PRs merge cleanly. (cherry picked from commit 36ca96c)
Contributor
|
Thank you @ree2507! This landed on main through #446, which stacked the 34 reviewed official-plugin PRs on current main so their shared files (CHANGELOGs, versions, the README grid) conflicted only once. Your commits are kept with your authorship; this PR's tip is 381f1dd. To get it now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #265 (the per-profile resume hint half)
What this changes
Importing a Grok Bot or OpenBot into a named profile printed
hermes cron resume <id>without a-pselector, so the hint failed whenpasted from any other profile — the resume ran against the caller's cron
store and reported
Job with ID or name '<id>' not found._print_routine_next_steps()now pins the hint to the profile the importtargeted, using core's
hermes_constants.profile_cli_selector()— the samehelper
hermes_cli/auth.pyanddoctor_state.pyuse for theircopy-pasteable guidance. The default profile keeps the bare
hermes cron resumeform, so single-profile behavior is unchanged.Testing
test_the_resume_hint_is_pasteable_from_a_named_profile(RED first: reproduced the missing
-p; GREEN after the fix). It mirrorsthe issue's repro: the profile home is created explicitly, the import runs,
and the output must contain
hermes -p scout cron resumewith no barehermes cron resumeform left.agent-importerssuite: 133 passed, 1 skipped (baseline was132 passed, 1 skipped — the only delta is the new test).
python -m hermes_cli.main plugins validate ./agent-importers→ passed.Scope
Touches only
agent-importers. The multi-Bot half of #265 (several Botsmerging into one agent / "one profile per Bot") is a design decision — I
would like to follow the maintainer's direction on it before coding, as
asked in the issue comment.