Skip to content

fix(xchat): select latest identity key instead of oldest - #283

Closed
creditlabsonarc-rgb wants to merge 4 commits into
NousResearch:mainfrom
creditlabsonarc-rgb:fix/xchat-latest-identity-key
Closed

creditlabsonarc-rgb wants to merge 4 commits into
NousResearch:mainfrom
creditlabsonarc-rgb:fix/xchat-latest-identity-key

Conversation

@creditlabsonarc-rgb

Copy link
Copy Markdown

_initiate_conversation selected records[0], which is the oldest public key when a recipient has rotated identities; X rejects any participant key that is not the account's latest, so the conversation key never seeds.

Select the record with the greatest public_key_version instead, comparing as integers (versions are millisecond timestamps whose string length can vary).

Closes #219.

salch-cred and others added 4 commits October 25, 2026 17:18
_initiate_conversation picked records[0], which is the oldest public key when a recipient has rotated identities; X rejects any participant key that is not the account latest. Select the record with the greatest public_key_version (compared as integers, since versions are millisecond timestamps whose string length can vary).

Closes NousResearch#219.
@teknium1

teknium1 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Thanks for working on this. #220 by @dacheah ("fix(xchat): wrap the newest identity version in the conversation-key handshake") fixes the same issue and was opened earlier, so we're keeping that one and closing this as a duplicate to keep one PR per issue. If yours covers a case #220 misses, say which in a comment on #220 and we'll fold it in with your credit.

@teknium1 teknium1 closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xchat: conversation-key handshake wraps a superseded identity version

4 participants