Repository navigation
fix(xchat): select latest identity key instead of oldest - #283
Closed
creditlabsonarc-rgb wants to merge 4 commits into
Closed
creditlabsonarc-rgb wants to merge 4 commits into
creditlabsonarc-rgb wants to merge 4 commits into
Conversation
_initiate_conversation picked records[0], which is the oldest public key when a recipient has rotated identities; X rejects any participant key that is not the account latest. Select the record with the greatest public_key_version (compared as integers, since versions are millisecond timestamps whose string length can vary). Closes NousResearch#219.
Contributor
|
Thanks for working on this. #220 by @dacheah ("fix(xchat): wrap the newest identity version in the conversation-key handshake") fixes the same issue and was opened earlier, so we're keeping that one and closing this as a duplicate to keep one PR per issue. If yours covers a case #220 misses, say which in a comment on #220 and we'll fold it in with your credit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_initiate_conversationselectedrecords[0], which is the oldest public key when a recipient has rotated identities; X rejects any participant key that is not the account's latest, so the conversation key never seeds.Select the record with the greatest
public_key_versioninstead, comparing as integers (versions are millisecond timestamps whose string length can vary).Closes #219.