Repository navigation
fix(agent-importers): record the import and count routines that need a schedule - #272
Closed
salch-cred wants to merge 3 commits into
Closed
salch-cred wants to merge 3 commits into
salch-cred wants to merge 3 commits into
Conversation
…a schedule After a Grok Bot import the agent did not know an import happened, so it offered to recreate routines that already exist as paused jobs. And a scheduled routine whose time is only in words was silently filed with the event routines, counted nowhere. The import now writes one memory entry per Bot (date, job names/ids, paused state, notes file, do-not-recreate), and schedule-triggered routines whose time does not parse get their own needs-a-schedule heading in the notes plus a counted summary line. Closes NousResearch#266.
salch-cred
force-pushed
the
fix/agent-importers-import-record
branch
from
November 6, 2026 03:19
e528e4b to
efb2ea0
Compare
…path The record told the agent the notes file's bare name 'in the same folder as this profile's grok-bot-import notes' — the exact lookup NousResearch#266 says the agent fails. It now carries the notes file's full path, and only when one was written. Job names come from the job, not by string-stripping the destination row; a notes file with only schedule-less routines no longer opens with an empty 'run on an event' section. Test pins the job id, the path and re-run idempotency of the record.
teknium1
force-pushed
the
fix/agent-importers-import-record
branch
from
November 19, 2026 12:25
ddc3525 to
5d3a78b
Compare
Contributor
|
Thank you @salch-cred! This landed on main through #446, which stacked the 34 reviewed official-plugin PRs on current main so their shared files (CHANGELOGs, versions, the README grid) conflicted only once. Your commits are kept with your authorship; this PR's tip is 0cbe503. To get it now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a Grok Bot import, the agent didn't know an import had happened: asked "which routines did I have?", it offered to set them up again (duplicates), and "recreate what was left out" never found the notes file. Separately, a scheduled routine whose time is only in words (
schedule_text: "Every month on the 15th at 9:00 AM") was silently filed under "routines that run on an event" — counted neither as imported nor skipped.# Routines that need a scheduleheading in the notes file and a counted summary line (1 routine(s) need a schedule set: VAT reminder), so every routine in the export is accounted for.Test covers the
schedule_text-only routine end to end.Closes #266.