Skip to content

fix(agent-importers): record the import and count routines that need a schedule - #272

Closed
salch-cred wants to merge 3 commits into
NousResearch:mainfrom
salch-cred:fix/agent-importers-import-record
Closed

salch-cred wants to merge 3 commits into
NousResearch:mainfrom
salch-cred:fix/agent-importers-import-record

Conversation

@salch-cred

Copy link
Copy Markdown
Contributor

After a Grok Bot import, the agent didn't know an import had happened: asked "which routines did I have?", it offered to set them up again (duplicates), and "recreate what was left out" never found the notes file. Separately, a scheduled routine whose time is only in words (schedule_text: "Every month on the 15th at 9:00 AM") was silently filed under "routines that run on an event" — counted neither as imported nor skipped.

  • One memory entry per import: date, Bot, the created job names/ids (paused), the notes file, and "do not recreate these routines — they already exist as cron jobs".
  • Schedule-triggered routines whose time doesn't parse get their own # Routines that need a schedule heading in the notes file and a counted summary line (1 routine(s) need a schedule set: VAT reminder), so every routine in the export is accounted for.

Test covers the schedule_text-only routine end to end.

Closes #266.

@salch-cred
salch-cred requested a review from teknium1 as a code owner November 3, 2026 13:00
…a schedule

After a Grok Bot import the agent did not know an import happened, so it offered to recreate routines that already exist as paused jobs. And a scheduled routine whose time is only in words was silently filed with the event routines, counted nowhere.

The import now writes one memory entry per Bot (date, job names/ids, paused state, notes file, do-not-recreate), and schedule-triggered routines whose time does not parse get their own needs-a-schedule heading in the notes plus a counted summary line.

Closes NousResearch#266.
@salch-cred
salch-cred force-pushed the fix/agent-importers-import-record branch from e528e4b to efb2ea0 Compare November 6, 2026 03:19
kanederkson and others added 2 commits November 6, 2026 08:53
…path

The record told the agent the notes file's bare name 'in the same folder as this
profile's grok-bot-import notes' — the exact lookup NousResearch#266 says the agent fails. It
now carries the notes file's full path, and only when one was written. Job names
come from the job, not by string-stripping the destination row; a notes file with
only schedule-less routines no longer opens with an empty 'run on an event'
section. Test pins the job id, the path and re-run idempotency of the record.
@teknium1

Copy link
Copy Markdown
Contributor

Thank you @salch-cred! This landed on main through #446, which stacked the 34 reviewed official-plugin PRs on current main so their shared files (CHANGELOGs, versions, the README grid) conflicted only once. Your commits are kept with your authorship; this PR's tip is 0cbe503. To get it now: hermes plugins install NousResearch/hermes-official-plugins#<plugin> --force; hermes plugins update follows once the catalog pin moves (in progress).

@teknium1 teknium1 closed this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[agent-importers] Grok Bot: tell the agent what was imported, and count routines that still need a schedule

3 participants