Skip to content

fix(agent-importers): deliver imported routines to the profile home channel - #271

Closed
salch-cred wants to merge 2 commits into
NousResearch:mainfrom
salch-cred:fix/agent-importers-imported-routine-delivery
Closed

salch-cred wants to merge 2 commits into
NousResearch:mainfrom
salch-cred:fix/agent-importers-imported-routine-delivery

Conversation

@salch-cred

Copy link
Copy Markdown
Contributor

Imported Grok Bot routines were created without deliver, so cron fell back to local: a resumed routine succeeded silently into ~/.hermes/cron/output/<id>/ and the user — coming from Grok Bot, where results show in the Bot's conversation — concluded it never ran.

The importer now resolves the target profile's first configured home channel (<PLATFORM>_HOME_CHANNEL in the process env or the profile's .env, or a home_channel in its config) and creates the job with that delivery. The preview row says where each routine will deliver; with no target available the job stays local and the summary prints each job's output folder plus its hermes cron edit <id> --deliver ... hint instead of the generic line.

Acceptance test included: importing into a home with TELEGRAM_HOME_CHANNEL set produces jobs whose deliver is telegram, not local.

Closes #264.

@salch-cred
salch-cred requested a review from teknium1 as a code owner November 3, 2026 12:58
…hannel

Imported Grok Bot routines were created without deliver, so cron fell back to local: a resumed routine succeeded silently into cron/output and the user concluded it never ran.

The importer now resolves the target profile's first configured home channel (<PLATFORM>_HOME_CHANNEL in the process env or the profile .env, or a home_channel in its config) and creates the job with that delivery; the preview row says where each routine will deliver. With no target the job stays local and the summary prints each job's output folder plus its hermes cron edit --deliver hint.

Closes NousResearch#264.
@salch-cred
salch-cred force-pushed the fix/agent-importers-imported-routine-delivery branch from d85d8a0 to 531100c Compare November 5, 2026 16:28
… not the launch env

The process env holds the launch profile's channels: a job imported into another
profile cannot deliver through them. Platform ids now match cron's deliver tokens
(qqbot; no bare qq). The config.yaml home_channel branch read PyYAML, which core no
longer ships; the broad except hid the ImportError, so it never matched — it now goes
through the plugin's load_config_file. The preview row (destination) carries
'delivers to <x>', and the local-output hint names the target profile's cron/output.
Test moved off the hunk NousResearch#290/NousResearch#394 edit so the three PRs merge cleanly.
@teknium1

Copy link
Copy Markdown
Contributor

Thank you @salch-cred! This landed on main through #446, which stacked the 34 reviewed official-plugin PRs on current main so their shared files (CHANGELOGs, versions, the README grid) conflicted only once. Your commits are kept with your authorship; this PR's tip is ce05b09. To get it now: hermes plugins install NousResearch/hermes-official-plugins#<plugin> --force; hermes plugins update follows once the catalog pin moves (in progress).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[agent-importers] Grok Bot: imported routines run, but their output lands nowhere the user looks

3 participants