Repository navigation
fix(agent-importers): deliver imported routines to the profile home channel - #271
Closed
salch-cred wants to merge 2 commits into
Closed
salch-cred wants to merge 2 commits into
salch-cred wants to merge 2 commits into
Conversation
…hannel Imported Grok Bot routines were created without deliver, so cron fell back to local: a resumed routine succeeded silently into cron/output and the user concluded it never ran. The importer now resolves the target profile's first configured home channel (<PLATFORM>_HOME_CHANNEL in the process env or the profile .env, or a home_channel in its config) and creates the job with that delivery; the preview row says where each routine will deliver. With no target the job stays local and the summary prints each job's output folder plus its hermes cron edit --deliver hint. Closes NousResearch#264.
salch-cred
force-pushed
the
fix/agent-importers-imported-routine-delivery
branch
from
November 5, 2026 16:28
d85d8a0 to
531100c
Compare
… not the launch env The process env holds the launch profile's channels: a job imported into another profile cannot deliver through them. Platform ids now match cron's deliver tokens (qqbot; no bare qq). The config.yaml home_channel branch read PyYAML, which core no longer ships; the broad except hid the ImportError, so it never matched — it now goes through the plugin's load_config_file. The preview row (destination) carries 'delivers to <x>', and the local-output hint names the target profile's cron/output. Test moved off the hunk NousResearch#290/NousResearch#394 edit so the three PRs merge cleanly.
Contributor
|
Thank you @salch-cred! This landed on main through #446, which stacked the 34 reviewed official-plugin PRs on current main so their shared files (CHANGELOGs, versions, the README grid) conflicted only once. Your commits are kept with your authorship; this PR's tip is ce05b09. To get it now: |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported Grok Bot routines were created without
deliver, so cron fell back tolocal: a resumed routine succeeded silently into~/.hermes/cron/output/<id>/and the user — coming from Grok Bot, where results show in the Bot's conversation — concluded it never ran.The importer now resolves the target profile's first configured home channel (
<PLATFORM>_HOME_CHANNELin the process env or the profile's.env, or ahome_channelin its config) and creates the job with that delivery. The preview row says where each routine will deliver; with no target available the job stayslocaland the summary prints each job's output folder plus itshermes cron edit <id> --deliver ...hint instead of the generic line.Acceptance test included: importing into a home with
TELEGRAM_HOME_CHANNELset produces jobs whosedeliveristelegram, notlocal.Closes #264.