Skip to content

PhysicsTool reads XML data incorrectly #289

Description

@Uhkko

I've encountered a problem where the PhysicsTool reads XML data incorrectly. More specifically, the vector values of the HalfExtents element of box geometries change seemingly at random. This seems to only affect the XML import as exporting existing binaries to XML works correctly, as does exporting a binary to another binary.

After playing around with the bytes and not finding anything I took a look at the source code and found what seems to be a typo in the PxLoader.cpp script. At line 403 it reads P(HalExtents, PxVec3) when it probably should be P(HalfExtents, PxVec3). To test this out I changed the element name in the XML to HalExtents and then it imported and exported correctly.

I haven't compiled it myself and tested whether correcting that typo actually fixes it, so I'm not gonna open a PR for it, but that does seem to be a likely culprit.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions