Skip to content

qt6.qtdeclarative: fix host tools for cross compilation - #561181

Open
johnrichardrinehart wants to merge 1 commit into
NixOS:masterfrom
johnrichardrinehart:qt6-cross-shader-tools
Open

johnrichardrinehart wants to merge 1 commit into
NixOS:masterfrom
johnrichardrinehart:qt6-cross-shader-tools

Conversation

@johnrichardrinehart

Copy link
Copy Markdown
Contributor

Description of changes

Fix the native shader-tool CMake package path: Qt6ShaderToolsTools_DIR must point to Qt6ShaderToolsTools, not Qt6ShaderTools. Also supply the native Qt6QuickTools_DIR during cross compilation.

Without the shader-tool fix, an aarch64-linux to x86_64-linux build completes Qt Declarative without Qt Quick. Its configuration reports: Qt Quick modules not built due to not finding the qtshadertools qsb tool. After enabling Quick, configuration also needs the native Quick tools package for Qt6::svgtoqml.

This was found while cross-building Audacity after #559623. The changes belong in Qt Declarative rather than an Audacity-specific workaround.

Verification

  • Applied these changes through an overlay on the Audacity verification revision and built Qt Declarative on an aarch64-linux host for x86_64-linux.
  • Qt Quick compiled successfully; the dependent Audacity cross-build passed Qt discovery and reached compilation.
  • Evaluated the cross-build CMake flags in this branch.
  • nixfmt --check passed.

AI assistance was used to investigate, implement, and validate this change.

@nixpkgs-branch-check nixpkgs-branch-check Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR's base branch is set to master, but this PR causes 1565 rebuilds.
It is therefore considered a mass rebuild.
Please change the base branch to the right base branch for your changes (probably staging).

@nixpkgs-ci
nixpkgs-ci Bot requested a review from a team September 8, 2026 08:12
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Sep 8, 2026
@K900

K900 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Please retarget to staging.

@ofborg ofborg Bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Sep 9, 2026
@SFrijters

Copy link
Copy Markdown
Member

Also see #550761
@doronbehar Functionally the same as 3234d29

@SFrijters
SFrijters requested a review from doronbehar September 9, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants