Repository navigation
audacity: respect the Darwin deployment target - #560876
Closed
johnrichardrinehart wants to merge 1 commit into
Closed
johnrichardrinehart wants to merge 1 commit into
johnrichardrinehart wants to merge 1 commit into
Conversation
Fetch the upstream deployment override fix and pass stdenv.hostPlatform.darwinMinVersion explicitly, keeping CMake and linker minimums consistent with the compiler wrapper. Preserve the separate upstream SDK-version rendering workaround. Upstream: audacity/audacity#12022 Assisted-by: OpenAI Codex / GPT-6-astra
johnrichardrinehart
force-pushed
the
audacity-3-darwin-deployment-target
branch
from
September 7, 2026 13:23
3d7e547 to
ce5befe
Compare
Contributor
|
Why did you modify the PR template? Please do not to that. Please both read all the listed guidelines in the template (they are there for a reason!), and reapply the template. Re-open the PR when you have done so, and a reviewer will get to your PR when they are able to. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Apply audacity/audacity#12022 using commit-pinned
fetchpatch2and passstdenv.hostPlatform.darwinMinVersionexplicitly. This keeps CMake and explicit linker minimums consistent with the compiler wrapper. Current nixpkgs defaults to macOS 14.0; overrides remain respected.The upstream fix synchronizes normal and cached CMake targets and enforces the Apple Silicon minimum of macOS 11.0. The separate upstream SDK-version rendering workaround is preserved.
This remains separate from the Audacity 4 upgrade in #559623.
Verification
Fetched patch applied to Audacity 3.7.9. Actual package flags selected 14.0 by default and 15.0 with an override for both architecture branches. Default/environment/explicit precedence and ARM64 minimum checks passed, including normal/cache consistency. Package evaluation and formatting passed. Native Darwin build/runtime verification remains outstanding.
Automation disclosure
OpenAI Codex / GPT-6-astra assisted with investigation, implementation, upstream submission, validation, and PR text. Draft pending native verification and human review.