libgphoto2: fix darwin build - #548661
Open
fullmetalsheep wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I am also happy to add myself to the maintainers list, if that's welcome. |
| gd | ||
| ] | ||
| ++ lib.optionals stdenv.hostPlatform.isDarwin [ | ||
| gettext # prevents darwin builds from breaking |
Contributor
There was a problem hiding this comment.
Suggested change
| gettext # prevents darwin builds from breaking | |
| gettext |
In my opinion this comment is not needed
Contributor
Author
There was a problem hiding this comment.
Fair, removed. Thanks!
BatteredBunny
approved these changes
Aug 3, 2026
- amended original commit with suggestion by @BatteredBunny applied. Thanks!
fullmetalsheep
force-pushed
the
libgphoto2-darwin-fix
branch
from
August 3, 2026 12:23
334fa61 to
60afd97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Originally caught this while building darktable on aarch64-darwin (which has a dependency on libgphoto2)
libgphoto2 fails to build on Darwin with linker errors due to missing _libintl_dgettext symbols. Logs below:
Fixed by adding
gettexttobuildInputswhen building for Darwin hosts. It should not affect any other platforms.Tested manually by building both
libgphoto2and the downstream packagedarktable. They build and function as expected.Hope this helps,
Thanks!
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.