queue-runner: do not fail uploads when the build log is missing#1792
Open
Mic92 wants to merge 1 commit into
Open
queue-runner: do not fail uploads when the build log is missing#1792Mic92 wants to merge 1 commit into
Mic92 wants to merge 1 commit into
Conversation
Ericson2314
approved these changes
Jun 11, 2026
upload_to_store opened the local build log and treated any error as fatal for the whole message, so paths without a log were never copied to the binary cache and their builds failed. Logs are legitimately absent for steps that did not run on this instance: substituted paths or builds finished before a queue runner restart. Observed on a 120-build nixos-small evaluation: 53 'Failed to upload ... uploader state I/O' errors in 10 minutes and 65 builds failing with status 2, with the corresponding build-logs directories empty. Skip the log upload with a warning when the file does not exist. Other I/O errors still fail the upload.
Mic92
force-pushed
the
uploader-missing-log
branch
from
444788a to
1000849
Compare
Conni2461
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upload_to_store opened the local build log and treated any error as fatal for the whole message, so paths without a log were never copied to the binary cache and their builds failed. Logs are legitimately absent for steps that did not run on this instance: substituted paths or builds finished before a queue runner restart.
Observed on a 120-build nixos-small evaluation: 53 'Failed to upload ... uploader state I/O' errors in 10 minutes and 65 builds failing with status 2, with the corresponding build-logs directories empty.
Skip the log upload with a warning when the file does not exist. Other I/O errors still fail the upload.