Fix: feature gate config and add feature matrix in CI - #43
Merged
Conversation
RajeshRk18
requested review from
cupicmarko,
frozenspider and
maksimryndin
as code owners
August 11, 2026 10:53
frozenspider
requested changes
Aug 11, 2026
Collaborator
There was a problem hiding this comment.
Thank you for your contribution, @RajeshRk18! While I love the idea of this PR and there's a real issue there, although I have some comments about the details. Let me know if you're up for addressing those.
RajeshRk18
force-pushed
the
fix/feature-matrix
branch
from
August 12, 2026 11:13
57f9058 to
84c32a8
Compare
RajeshRk18
force-pushed
the
fix/feature-matrix
branch
from
August 12, 2026 12:21
84c32a8 to
3e54e9a
Compare
frozenspider
approved these changes
Aug 12, 2026
frozenspider
left a comment
frozenspider
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @RajeshRk18!
Collaborator
|
@RajeshRk18, could you please sign your commit and force-push it so I can merge it? |
RajeshRk18
force-pushed
the
fix/feature-matrix
branch
from
August 12, 2026 12:54
3e54e9a to
09c7ad9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I started to work on issue #40 but the current build is broken(
cargo build --no-default-features). the ci might pass because it runs withall-featuresflag. It builds fine with default build as well.Problem
syn::Pathrequiresextra-traitsfeature which is pulled by an arkworks crate. I removed Debug derive anyway fromOpbecause its not needed now. Features are not independent and some of them usedep/featureform. For eg:serdefeature pullscrypto-bigintunconditionally.Fixes
I fixed with conditional
dep?/feature. Also added a feature matix in CI which builds with every combination to check if any fails. And some other minor dep fixes