Skip to content

MP3 player + Root menu multi-keybinding + NeoUI minor changes#1951

Open
nullsystem wants to merge 2 commits intoNeotokyoRebuild:masterfrom
nullsystem:MP3NeoUIMinorChanges
Open

MP3 player + Root menu multi-keybinding + NeoUI minor changes#1951
nullsystem wants to merge 2 commits intoNeotokyoRebuild:masterfrom
nullsystem:MP3NeoUIMinorChanges

Conversation

@nullsystem
Copy link
Copy Markdown
Collaborator

Description

  • Main root menu now responds to neo_mp3 bind
  • NeoUI::ProgressDrag fix not immediately responding on click
  • New NeoUI::Bind for named keybinds

Toolchain

  • Linux GCC Distro Native Arch/GCC 15

@nullsystem nullsystem requested a review from a team April 18, 2026 12:04
AdamTadeusz
AdamTadeusz previously approved these changes Apr 23, 2026
@AdamTadeusz AdamTadeusz requested a review from a team April 23, 2026 14:52
@Rainyan Rainyan requested review from Rainyan and removed request for a team April 25, 2026 16:38
Copy link
Copy Markdown
Member

@Rainyan Rainyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure whether this is working correctly since I don't really know what the expected behavior is, but I'm seeing the following:

  • When entering neo_mp3 in the dev console, the main menu music either stops playing or resumes playing - is this intended?
  • When binding bind p "neo_mp3" and pressing the keyboard key P in the main menu, nothing happens - is this intended?

Comment thread src/game/client/neo/ui/neo_ui.cpp Outdated
* Main root menu now responds to `neo_mp3` bind
* `NeoUI::ProgressDrag` fix not immediately responding on click
* New `NeoUI::Bind` for named keybinds
@nullsystem
Copy link
Copy Markdown
Collaborator Author

@Rainyan

  • neo_mp3 is now changed to just doing pause/play music toggle so that's expected.
  • I think that was down to gameuifuncs->GetButtonCodeForBind not supporting multiple bindings so whatever it think is first is picked up instead. This is also noted as a TODO in neo_root.cpp regarding keys.bcConsole. Could try to do a workaround which was already present for the settings menu where all keys were checked and put into a hashtable: htAllBinds variable in neo_root_settings.cpp but hashtable updated limited to like a InstallChangeCallback

neo_mp3 can now be handled by multiple binds. neo_toggleconsole
also however it's limited to single due to keybind enforce
workaround causing issue with console multi-keybinds and unable
to figure out multi binds here somewhat.

Settings button also updated to single key for console.
@nullsystem
Copy link
Copy Markdown
Collaborator Author

@Rainyan I've updated how the root main menu deal with keybinds: a132708
Now it's able to deal with multiple keybinds, but I had ended up limiting the console's keybind setting UI due to unable with getting the toggleconsole enforce to deal with multiple binds. It already had that issue to prior to this PR.

@nullsystem nullsystem changed the title MP3 player + NeoUI minor changes MP3 player + Root menu multi-keybinding + NeoUI minor changes Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants