MP3 player + Root menu multi-keybinding + NeoUI minor changes#1951
Open
nullsystem wants to merge 2 commits intoNeotokyoRebuild:masterfrom
Open
MP3 player + Root menu multi-keybinding + NeoUI minor changes#1951nullsystem wants to merge 2 commits intoNeotokyoRebuild:masterfrom
nullsystem wants to merge 2 commits intoNeotokyoRebuild:masterfrom
Conversation
AdamTadeusz
previously approved these changes
Apr 23, 2026
Rainyan
reviewed
Apr 25, 2026
Member
There was a problem hiding this comment.
I'm unsure whether this is working correctly since I don't really know what the expected behavior is, but I'm seeing the following:
- When entering
neo_mp3in the dev console, the main menu music either stops playing or resumes playing - is this intended? - When binding
bind p "neo_mp3"and pressing the keyboard key P in the main menu, nothing happens - is this intended?
* Main root menu now responds to `neo_mp3` bind * `NeoUI::ProgressDrag` fix not immediately responding on click * New `NeoUI::Bind` for named keybinds
Collaborator
Author
|
neo_mp3 can now be handled by multiple binds. neo_toggleconsole also however it's limited to single due to keybind enforce workaround causing issue with console multi-keybinds and unable to figure out multi binds here somewhat. Settings button also updated to single key for console.
3d6b1e2 to
a132708
Compare
Collaborator
Author
|
@Rainyan I've updated how the root main menu deal with keybinds: a132708 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
neo_mp3bindNeoUI::ProgressDragfix not immediately responding on clickNeoUI::Bindfor named keybindsToolchain